| Summary: | vrb-0.3.0.ebuild (New Ebuild) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Johannes Findeisen <you> |
| Component: | New packages | Assignee: | Arcady Genkin (RETIRED) <agenkin> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | you |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
The Ebuild Script
Add CFLAGS support |
||
|
Description
Johannes Findeisen
2002-05-24 09:37:17 UTC
Created attachment 1124 [details]
The Ebuild Script
Hi, Johanes: A few comments on your ebuild: 1. src_unpack is redundant if all it does is 'unpack'. 2. Anyhow, if you needed to refer to the .tar.gz file, you could use $A variable (as in 'Archive'). 3. There is no need to explicitely cd into $S in the beginning of src_compile and src_install. 4. It's very important to make sure that the contents of CFLAGS is used during the compilation. It seems that in case of vrb you need to hack the Makefiles to make that happen, but it has to be done. If you don't feel like doing all that yourself, that's fine, but since I see that this is not your first ebuild submission, I thought that you can use some feedback. Well, for the most part, that is correct; except for the fact that you are
strongly DIScouraged from using $A. Please use ${P}.tar.gz instead.
Seemant: thanks, I was not aware of that. I thought that the discouragement was only for *setting* the A variable. Anyways, since I got involved with this bug, I guess that I'll take it. [Reassigning to agenkin@gentoo.org] Created attachment 1208 [details]
Add CFLAGS support
hello arcady, here is a new ebuild script for the vrb-library. i hope it is the
right way now. i have used "sed" for hacking the install scripts. i wouldn't
hack the makefiles, so i hacked the Configure script from where the makefiles
are generated. on my machine it works... ;-) regards - hanez
What were you creating directory /usr/include/vrb for? I've committed the ebuild to the portage tree. I hope that dev-lib was the best category for it. Sorry it took me so long to get to it. Thanks. |
