Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 298150

Summary: media-video/cclive fetches porn videos during src_test
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo, qa
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Build log

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-12-23 23:40:37 UTC
You know, I'm glad I'm running the tinderbox from my home and not from a co-location because I would have *a bit of a hard time* to explain why I've been fetching porn videos in such a case.

Check the attached build log.

Please, just restrict the tests or put it under an offensive USE flag or something, this doesn't look any right at all.
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-12-23 23:41:18 UTC
Created attachment 213992 [details]
Build log
Comment 2 Ken Rushia 2009-12-24 00:10:42 UTC
Actually, I'd suggest adding a local USE flag for each supported site (and of course clear descriptions for each one).

Also as a side note, I think any business locations would be more concerned about the hundreds of MB of video downloads you did than exactly which ones they were. Consider not using the test feature in a formal environment :P
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-12-24 00:13:50 UTC
Point is that the whole point of running the tinderbox is checking the testsuites. And all the tests *have* to be runnable in formal environments.
Comment 4 SpanKY gentoo-dev 2009-12-24 01:44:44 UTC
dont run the tests then.  upstream specifically added support to cclive to fetch porn videos.  there's nothing offensive in having support compiled into the program itself.
Comment 5 Tomáš Chvátal (RETIRED) gentoo-dev 2009-12-24 11:50:30 UTC
This package tests require by default internet connection to be working.
How else would you test if the api changed for the site to test fetching.
If those tests are bad due to their nature how about adding useflag tests and ewarn user that he really needs to have working net connection for this thing to work?
Comment 6 Tomáš Chvátal (RETIRED) gentoo-dev 2009-12-24 12:21:03 UTC
Bumped to latest 0.5.7 and added offensive useflag to switch between fetching p0rn or not.
and created 2 reports:
http://code.google.com/p/cclive/issues/detail?id=19
http://code.google.com/p/cclive/issues/detail?id=20
Comment 7 Mark Loeser (RETIRED) gentoo-dev 2010-09-03 22:21:39 UTC
Looks like this is fixed...