Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 297541

Summary: Repoman could print upstream.workaround if there is a reference to "no-as-needed" in a ebuild
Product: Gentoo Linux Reporter: Samuli Suominen (RETIRED) <ssuominen>
Component: Current packagesAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal CC: binki, qa
Priority: High Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 234710, 288499    
Attachments: Patch to repoman

Description Samuli Suominen (RETIRED) gentoo-dev 2009-12-19 17:04:22 UTC
The correct way to workaround -Wl,--as-needed failures is,

inherit flag-o-matic

[ .. ]

append-ldflags $(no-as-needed)

[ .. ]

Using above doesn't mean you can close valid asneeded bugs as resolved, fixed, because, in principle, it's same as using "emake -j1" or MAKEOPTS="${MAKEOPTS} -j1" in a ebuild.

So what I'm suggesting is a new repoman warning, like upstream.workaround if repoman sees the wording "no-as-needed" present in a ebuild, like it does for -j1 currently.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-12-19 17:16:29 UTC
Created attachment 213482 [details, diff]
Patch to repoman

Suggested patch to repoman
Comment 2 Zac Medico gentoo-dev 2009-12-21 05:16:07 UTC
Thanks, this is in svn r15128.
Comment 3 Zac Medico gentoo-dev 2009-12-24 06:30:05 UTC
This is fixed in 2.1.7.16 and 2.2_rc61.