Summary: | dev-python/python-yadis fails tests | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Python Gentoo Team <python> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Build log
ebuild patch the expanded python-yadis patch |
Description
Diego Elio Pettenò (RETIRED)
2009-12-15 23:07:06 UTC
Missing build log. Created attachment 213226 [details]
Build log
Even if I correct the errors found here: https://bugs.gentoo.org/show_bug.cgi?id=298118 , It fails for me. Not same output as in this build log though - not quite sure why this fails unless pyflakes returns an error code (which a comment in the ebuild tells us to disregard). I'll dig some more.. OK, ebuild/patch in bug @ comment above should fix this by having proper dependencies and not running pyflakes as part of the test suite. Created attachment 292769 [details, diff]
ebuild patch
To sed or not to sed, that is the queastion.
I have left all of the sed statements to apply the fix commented out. They work ofcourse. The last one just couldn't jag the statement since it needed to change 12 of two identical lines. The use of the present patch file seems the more elegant approach.
Created attachment 292771 [details, diff] the expanded python-yadis patch The cause of these 2 errors is from the devs making a "clever' decision to make, on three occasions, two similar but different function / module names identical. The test gets to them and trips up; variable defined but not used. Seeing there are no optional use flags, the inclusion of these is proven to be not required. The first two are commented out, not both, but one of each pair, leaving a single function of the duplicated name. The third I manged to give different names with no undesired outcomes subsequent. python-yadis # ebuild python-yadis-1.1.0.ebuild clean test >>> Source compiled. * Testing of dev-python/python-yadis-1.1.0 with CPython 2.7... Checking code (pyflakes)... OK. Running tests... putting . in sys.path ................................................................................. ---------------------------------------------------------------------- Ran 81 tests in 0.031s OK * The pyflake output about XML* redefinitions can be safely ignored Why It "changed its mind' I cannot fathom. It is fixed. Updated test patch, thanks. |