Bug 296952

Summary:	media-video/mpeg-tools: pre-stripped files found
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	QA	Keywords:	InVCS
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	239866
Attachments:	Build log

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-12-14 22:12:39 UTC

Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

For what concerns pre-built packages, you should set the QA_PRESTRIPPED variable in the ebuild with the list of known pre-stripped objects in the package.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-12-14 22:12:59 UTC

Created attachment 213040 [details]
Build log

Comment 2 Kevin Pyle 2009-12-15 06:00:16 UTC

The target for mpeg_encode, at Makefile:205, explicitly strips mpeg_encode after building it.  Even worse, they do not use a qualified name for strip, so it may fail to strip properly when cross-compiled.  Deleting the explicit strip at line 207 should fix the QA problem.

Comment 3 Justin Lecher (RETIRED) gentoo-dev

2010-02-04 23:48:21 UTC

Thanks Kevin for the hint.