Summary: | sys-kernel/gentoo-sources-2.6.32: compile error with CONFIG_RTL8187SE and CONFIG_MAC80211 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marshall Banana <JackyRyan> |
Component: | [OLD] Core system | Assignee: | Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
URL: | http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=df574b8ecfb3a84af96229f336a6be88ca4a7055 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
dirty patch
Patch to avoid kernel compile errors |
Description
Marshall Banana
2009-12-14 18:52:59 UTC
CONFIG_MAC80211 is not needed though for the RTL8187SE staging driver to work (in 2.6.32... not sure right now about 2.6.31-* if it was needed there) Thanks for spotting this bug Marshall Banana! I passed it upstream to the linux-wireless gentlemen: http://article.gmane.org/gmane.linux.kernel.wireless.general/44483 Created attachment 213056 [details, diff]
dirty patch
Attached you will find a *really* *really* dirty hotfix for your problem.
I have not compiled or tested it and I'm really not sure whether it will work.
It's basically three sed commands ran on the rtl8187se directory to rename the defective functions to something a bit more unique to avoid collisions.
I really can't stress how dirty and awful it is (sed renamed 5-6 functions that were not defective but matched the regexp) but it *may* get the job done 'till upstream gets to it.
<snip>
> Attached you will find a *really* *really* dirty hotfix for your problem.
> I have not compiled or tested it and I'm really not sure whether it will work.
<snip>
please bear with me if i won't compile/test that "dirtfix" right now either.
since i don't actually need mac80211 right now, i took the easy way and just removed that option momentarily (didn't try compiling it as module), waiting for upstream to fix it...
Created attachment 213090 [details]
Patch to avoid kernel compile errors
Hello, could you try patching your 2.6.32 kernel with the attached patch and see if it compiles and runs fine?
(In reply to comment #5) > Created an attachment (id=213090) [details] > Patch to avoid kernel compile errors > > Hello, could you try patching your 2.6.32 kernel with the attached patch and > see if it compiles and runs fine? > ok, so i don't have to work on my projects i procrastinated a bit by trying it and so far it is working fine... one question though: in what circumstances are the wake_queue and stop_queue functions called, so i know how to test if those work properly? (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=213090) [details] [details] > > Patch to avoid kernel compile errors > > > > Hello, could you try patching your 2.6.32 kernel with the attached patch and > > see if it compiles and runs fine? > > > > ok, so i don't have to work on my projects i procrastinated a bit by trying it > and so far it is working fine... > > one question though: in what circumstances are the wake_queue and stop_queue > functions called, so i know how to test if those work properly? > Unfortunately, I cannot help you with that 'cause my knowledge is quite limited. As far as I know, wake_queue and stop_queue are referring to the netif queue. They are used to wake and stop the queue accordingly when needed, like when the interface can't take any more data (whatever the reason) or when flow control is enforced. You could try sending a message to the kernelnewbies [1] mailing list and you will get a reply soon enough :) Thanks for testing the patch. This bug report is gonna stay open 'till the patch gets approved from upstream and gets added to the genpatches SVN trunk. [1]: http://kernelnewbies.org/ML Patches submitted upstream: http://driverdev.linuxdriverproject.org/pipermail/devel/2009-December/003419.html Released in gentoo-sources-2.6.32-r6 |