Bug 296654 – sci-electronics/geda test phase causes make forkbomb

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2009-12-12 19:33:11 UTC]

Somehow it goes in infinite recursion, this is *not* good!

Please confirm and eventually restrict test on that package, thanks!

[Comment 1 Thomas Beierlein 2009-12-19 09:43:05 UTC]

Hmm, Diego, I wonder as there is no sci-electronics/geda-gaf in the tree. 
Can you please recheck?

[Comment 2 Thomas Beierlein 2009-12-19 12:35:55 UTC]

I think you mean =sci-electonics/geda-1.6.0-r1.
That package fails here too during test with your stated problem.

[Comment 3 Diego Elio Pettenò (RETIRED) 2009-12-19 12:40:28 UTC]

Yeah sorry not -gaf in there :)

[Comment 4 Thomas Beierlein 2009-12-19 19:25:00 UTC]

After some fiddling with the problem it finds an easy solution.

Add the following src_test() to the ebuild and all goes well.

src_test() {
        cd "${S}"
        emake -j1 check || die "test failed"
}

Btw: The first tests on AMD64 are promising. The ebuild works well and seems to be made nicely.

One question arises however on the definition of RDEPEND:

RDEPEND="${RDEPEND}
    sci-electronics/electronics-menu"

I am wondering if that should DEPEND or CDEPEND.

[Comment 5 Rafael Martins (RETIRED) 2009-12-19 19:36:04 UTC]

(In reply to comment #4)
> After some fiddling with the problem it finds an easy solution.
> 
> Add the following src_test() to the ebuild and all goes well.
> 
> src_test() {
>         cd "${S}"
>         emake -j1 check || die "test failed"
> }
> 
> Btw: The first tests on AMD64 are promising. The ebuild works well and seems to
> be made nicely.

I'll test this solution. 

> One question arises however on the definition of RDEPEND:
> 
> RDEPEND="${RDEPEND}
>     sci-electronics/electronics-menu"
> 
> I am wondering if that should DEPEND or CDEPEND.
> 

Yes, it's wrong. The right var is ${CDEPEND}

[Comment 6 Rafael Martins (RETIRED) 2009-12-19 20:12:08 UTC]

Created attachment 213498 [details, diff]
patch to geda-1.6.0-r1.ebuild

This patch (with Thomas's fixes :) fix this bug.

Unfortunatelly Denis is away, and I haven't commit privileges yet, so would be great if someone can commit this.

Thanks

[Comment 7 Diego Elio Pettenò (RETIRED) 2009-12-22 23:15:56 UTC]

After hitting this once again and almost losing the tinderbox I committed it ;)

Let's hope it's all fixed by this (I'm a bit doubtful to be honest because I think it _was_ already running it that way, but still).