Bug 296544

Summary:	kde-base/solid patch to fix bug #295600 causes screen brightness to reset to 0
Product:	Gentoo Linux	Reporter:	Nate Weibley <nweibley>
Component:	[OLD] KDE	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aidanamarks, b.brachaczek, bugs, dschridde+gentoobugs, erpalma2003, ganellon, hanno, kripton, Magnus.Kessler, me, public, qt, rb6, realnc, rhill, schulz.benjamin, tschenturs
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.kde.org/show_bug.cgi?id=217316
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	295600
Bug Blocks:
Attachments:	Ebuild Corrected previous patch New powermanager patch

Description Nate Weibley 2009-12-11 18:32:29 UTC

There is a bug in the patch applied as a result of bug 295600. Whenever the Battery plasmoid is clicked the screen brightness is set down to 0 and the slider defaults to the lowest position regardless of active profile or default brightness. The screensaver also seems to trigger this behavior (or the system does not properly restore brightness after dimming for the screensaver) as do potentially other things (it may happen randomly with time, not sure).

I attached gdb to plasma-desktop and stepped through execution and found that execution never branches into halpower.cpp:388 leading me to believe deviceList is not populated correctly anymore and the changes in revision 1035622 were what actually caused the bug.

If I get time I will verify (currently in the midst of univ. exams so if someone else could verify it will probably be quicker). Obviously this will need to be reported upstream for the final fix.

Comment 1 Nate Weibley 2009-12-11 19:12:51 UTC

Reported upstream:
https://bugs.kde.org/show_bug.cgi?id=196232

Pending svn commit for a new patch for solid-4.3.4-r2

Comment 2 Nate Weibley 2009-12-13 06:09:01 UTC

I was too frustrated by this to wait to finish my exams so I went ahead and too the time to squash it. 

Attached is the new ebuild, modified original patch, and the new patch which together fix two bugs. I will report this upstream so they know to investigate.

Thanks
---Nate

Comment 3 Nate Weibley 2009-12-13 06:12:30 UTC

Created attachment 212849 [details]
Ebuild

Forgot to mention, I tested this against hal-0.5.13-r2 and 0.5.14 (most recent in portage tree which bought this bug up).

Comment 4 Nate Weibley 2009-12-13 06:13:01 UTC

Created attachment 212851 [details, diff]
Corrected previous patch

Comment 5 Nate Weibley 2009-12-13 06:13:30 UTC

Created attachment 212852 [details, diff]
New powermanager patch

Comment 6 Magnus Kessler 2009-12-13 10:02:42 UTC

Tested with hal-0.14, Qt-4.6. Works fine. Many thanks for taking this up!

Comment 7 Nate Weibley 2009-12-14 23:14:49 UTC

Patched upstream per bugs:
http://bugs.kde.org/show_bug.cgi?id=217316
http://bugs.kde.org/show_bug.cgi?id=196232

Comment 8 Samuli Suominen (RETIRED) gentoo-dev

2009-12-16 13:51:49 UTC

*** Bug 297166 has been marked as a duplicate of this bug. ***

Comment 9 Samuli Suominen (RETIRED) gentoo-dev

2009-12-16 14:55:43 UTC

+*solid-4.3.4-r2 (16 Dec 2009)
+
+  16 Dec 2009; Samuli Suominen <ssuominen@gentoo.org>
+  -solid-4.3.4-r1.ebuild, +solid-4.3.4-r2.ebuild,
+  files/solid-4.3.4-hal.patch:
+  Update HAL 0.5.14 patch wrt #296544 by Nate Weibley.

Comment 10 Denis Sokolovsky 2010-01-09 09:36:40 UTC

This patch resolve issue (for me) only in the way that setting brightness stop work too.
I must open new bug or reopen this?