Bug 296401 – Please remove C(XX)FLAGS checks from profiles/arch/amd64/profile.bashrc

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sebastian Luther (few) 2009-12-10 13:34:28 UTC]

profiles/arch/amd64/profile.bashrc contains several checks and filters that manipulate the user's C(XX)FLAGS. This is wrong for many reasons. To name some (in no particular order):

* Inconsistent across profiles, only amd64 has it.
* User should know asap if he has a typo in his C(XX)FLAGS. The filter issues a small warning at the beginning of the build that is easy to over look.
* The user might use another compiler that understands this flag.
* gcc might support a new flag that is filtered because it wasn't previously supported.
* The checks can never be complete.

[Comment 1 Łukasz Michalik 2009-12-10 15:01:47 UTC]

Just to clarify: those functions check if a flag is supported by current compiler and filter them out if they are not.  That discards 3 last points of the above, with 2nd last point being inverted -- gcc might stop supporting given option and user never realizes.

I do understand that killing that file might generate lots of duplicate bugs (as users had the possibility to insert typos for about 20 months), therefore I propose to change filtering into die()ing with a useful description of what went wrong.

[Comment 2 Mark Loeser (RETIRED) 2010-08-22 20:35:38 UTC]

AMD64: Could we please rip these out of here?  It doesn't seem like a very good idea.  Let me know and I'll take care of it.

[Comment 3 Markos Chandras (RETIRED) 2010-08-22 20:37:30 UTC]

(In reply to comment #2)
> AMD64: Could we please rip these out of here?  It doesn't seem like a very good
> idea.  Let me know and I'll take care of it.
> 

Mark feel free to do it yourself since I do have other amd64 related things in my TODO list atm. Thanks

[Comment 4 Mark Loeser (RETIRED) 2010-08-22 21:38:51 UTC]

Got rid of the profile.bashrc entirely since that's all it did.