Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 296242

Summary: media-gfx/gimp-9999 fails to compile
Product: Gentoo Linux Reporter: Vladimir Berezhnoy <non7top>
Component: Current packagesAssignee: Hanno Böck <hanno>
Severity: normal CC: gef.kornflakes, peach
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Attachments: patch to fix compilation

Description Vladimir Berezhnoy 2009-12-08 18:43:34 UTC
* CPV:  media-gfx/gimp-9999                                                                                                                                                                                        
 * REPO: gentoo                                                                                                                                                                                                     
 * USE:  alsa curl dbus elibc_glibc exif gnome hal jpeg kernel_linux mmx mng pdf png python sse svg tiff userland_GNU webkit x86                                                                                    
>>> Unpacking source...                                                                                                                                                                                             
 * GIT NEW clone -->                                                                                                                                                                                                
 *    repository:               git://                                                                                                                                                            
Initialized empty Git repository in /mnt/large/distfiles/git-src/gimp/                                                                                                                                              
remote: Counting objects: 312778, done.
remote: Compressing objects: 100% (48981/48981), done.
remote: Total 312778 (delta 270613), reused 304186 (delta 263230)
Receiving objects: 100% (312778/312778), 164.22 MiB | 81 KiB/s, done.
Resolving deltas: 100% (270613/270613), done.                        
 *    at the commit:            a736b8f972a821903b71d08bed394abbb8d47beb
 *    branch:                   master                                  
 *    storage directory:        "/mnt/large/distfiles/git-src/gimp"     
Initialized empty Git repository in /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/.git/
Switched to a new branch 'branch-master'                                                     
>>> Unpacked to /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999                          
>>> Source unpacked in /var/tmp/portage/media-gfx/gimp-9999/work                             
>>> Preparing source in /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999 ...              

I am testing that you have the tools required to build the
GNU Image Manipulation Program from git. This test is not foolproof,
so if anything goes wrong, see the file HACKING for more information...

checking for libtool >= 1.5 ... Major version might be too new (2.2.6)
checking for gtkdocize ...                                            
  You must have gtk-doc installed to compile GNU Image Manipulation Program.
  Install the appropriate package for your distribution,                    
  or get the source tarball at                                                                  
  You can also use the option --disable-gtk-doc to skip                     
  this test but then you will not be able to generate a                     
  configure script that can build the API documentation.                    
checking for autoconf >= 2.54 ... yes (version 2.63)                        
checking for automake >= 1.9.6 ... yes (version 1.9.6)                      
checking for intltool >= 0.40.1 ... yes (version 0.40.6)                    
checking for xsltproc ... yes                                               

Please install/upgrade the missing tools and call me again.

 * Fixing OMF Makefiles ...                                                                                                                                                                                    [ ok ]
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999 ...
 * ERROR: media-gfx/gimp-9999 failed:
 *   no configure script found
 * Call stack:
 *, line   49:  Called src_configure
 *   environment, line 3758:  Called gnome2_src_configure
 *   environment, line 2486:  Called econf '--enable-default-binary' '--with-x' '--without-aa' '--with-alsa' '--disable-altivec' '--with-libcurl' '--with-dbus' '--with-hal' '--with-gvfs' '--without-gnomevfs' '--with-webkit' '--with-libjpeg' '--with-libexif' '--without-lcms' '--enable-mmx' '--with-libmng' '--with-poppler' '--with-libpng' '--enable-python' '--disable-mp' '--enable-sse' '--with-librsvg' '--with-libtiff' '--without-wmf' '--disable-gtk-doc'
 *, line  544:  Called die
 * The specific snippet of code:
 *              die "no configure script found"
 * If you need support, post the output of 'emerge --info =media-gfx/gimp-9999',
 * the complete build log and the output of 'emerge -pqv =media-gfx/gimp-9999'.
 * The complete build log is located at '/var/log/portage/media-gfx:gimp-9999:20091208-171731.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-gfx/gimp-9999/temp/environment'.
 * S: '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999'

Reproducible: Always

Steps to Reproduce:
Comment 1 Vladimir Berezhnoy 2009-12-08 18:47:53 UTC
it works after installing dev-util/gtk-doc
Comment 2 Vladimir Berezhnoy 2009-12-08 19:01:05 UTC
well, it fails later anyway

libtool: compile:  i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include -DGIMP_DISABLE_DEPRECATED -DBABL_DISABLE_DEPRECATED -DGSEAL_ENABLE -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -O2 -march=native -pipe -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definition -Wmissing-format-attribute -Wformat-security -MT libcolor_selector_cmyk_la-color-selector-cmyk.lo -MD -MP -MF .deps/libcolor_selector_cmyk_la-color-selector-cmyk.Tpo -c color-selector-cmyk.c  -fPIC -DPIC -o .libs/libcolor_selector_cmyk_la-color-selector-cmyk.o                                                                         
color-selector-cmyk.c: In function 'colorsel_cmyk_adj_update':                                                                                                                                                       
color-selector-cmyk.c:230: error: 'GtkAdjustment' has no member named 'value'                                                                                                                                        
color-selector-cmyk.c:233: error: 'GtkAdjustment' has no member named 'value'                                                                                                                                        
color-selector-cmyk.c:236: error: 'GtkAdjustment' has no member named 'value'                                                                                                                                        
color-selector-cmyk.c:239: error: 'GtkAdjustment' has no member named 'value'
color-selector-cmyk.c: In function 'colorsel_cmyk_pullout_update':
color-selector-cmyk.c:257: error: 'GtkAdjustment' has no member named 'value'
make[2]: *** [libcolor_selector_cmyk_la-color-selector-cmyk.lo] Error 1
make[2]: Leaving directory `/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/modules'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999'
make: *** [all] Error 2
Comment 3 Matteo 'The Peach' Pescarin 2009-12-09 16:03:58 UTC
if you pass --disable-gtk-doc to it will go on. Probably we just need to add the doc flag check in a correct way. 
Comment 4 Daniel Prior 2009-12-16 13:02:57 UTC
with this changes, it will compile:

--- /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/modules/color-selector-cmyk.c        2009-11-04 17:37:24.725382043 +0100
+++ patched-color-selector-cmyk.c      2009-12-16 13:37:03.000000000 +0100
@@ -219,24 +219,26 @@
   GimpColorSelector *selector = GIMP_COLOR_SELECTOR (module);
   gint               i;
+  gdouble value;

   for (i = 0; i < 4; i++)
     if (module->adj[i] == adj)
+  value = gtk_adjustment_get_value (adj) / 100.0;

   switch (i)
     case 0:
-      module->cmyk.c = adj->value / 100.0;
+      module->cmyk.c = value;
     case 1:
-      module->cmyk.m = adj->value / 100.0;
+      module->cmyk.m = value;
     case 2:
-      module->cmyk.y = adj->value / 100.0;
+      module->cmyk.y = value;
     case 3:
-      module->cmyk.k = adj->value / 100.0;
+      module->cmyk.k = value;
@@ -253,8 +255,10 @@
                               ColorselCmyk  *module)
   GimpColorSelector *selector = GIMP_COLOR_SELECTOR (module);
+  gdouble value;
+  value = gtk_adjustment_get_value (adj) / 100.0;

-  module->pullout = adj->value / 100.0;
+  module->pullout = value;

   gimp_color_selector_set_color (selector, &selector->rgb, &selector->hsv);
Comment 5 Vladimir Berezhnoy 2009-12-16 21:54:26 UTC
(In reply to comment #4)
thanks, it compiles fine with the patch.

working ebuild is now in arcon overlay
Comment 6 Vladimir Berezhnoy 2009-12-16 21:55:25 UTC
Created attachment 213241 [details, diff]
patch to fix compilation
Comment 7 Andrzej Krentosz 2010-02-06 02:02:26 UTC
Correct flag is passed: '--disable-gtk-doc', you can see it in error message. It fails anyway.
Comment 8 Vladimir Berezhnoy 2010-03-19 00:26:46 UTC
(In reply to comment #4)
> with this changes, it will compile:
the patch no longer works unfortunately :( orginal bug with gtk-doc is also still unfixed 

Comment 9 Matteo 'The Peach' Pescarin 2010-03-21 17:07:36 UTC
Created attachment 224563 [details]

I've managed to install it couple of weeks ago with this ebuild, I've forced --disable-gtk-doc flag, and a couple of other things. Still I don't know if recent changes broke it again, so feel free to test it and see if it's working. Mind that you'll need git versions of gegl and babl for the configure to finish successfully.
Comment 10 Gef 2010-03-30 12:00:47 UTC has to be invocated with --disable-gtk-doc :
./ --disable-gtk-doc
during src_prepare if you want to build gimp-9999 without gtk-doc installed.

ATM, (commit ba9b0c12c7f3f16e43cb83a6740cdb3c7c9345c0), gimp-9999 compiles fine against gegl-0.1.2 and babl-0.1.2, with USE="alsa dbus exif hal jpeg mmx mng pdf png python smp sse svg tiff -aalib -curl -debug -doc -gnome -lcms -webkit -wmf", ~amd64.
Comment 11 Vicente Olivert Riera (RETIRED) gentoo-dev 2010-09-01 09:41:04 UTC
The ebuild needs to have two lines in RDEPEND for >=media-libs/babl-0.1.2 and >=media-libs/gegl-0.1.2 dependences.