Summary: | media-gfx/gimp-9999 fails to compile | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Vladimir Berezhnoy <non7top> |
Component: | Current packages | Assignee: | Hanno Böck <hanno> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | gef.kornflakes, peach |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch to fix compilation
media-gfx/gimp-9999.ebuild |
Description
Vladimir Berezhnoy
2009-12-08 18:43:34 UTC
it works after installing dev-util/gtk-doc well, it fails later anyway libtool: compile: i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include -DGIMP_DISABLE_DEPRECATED -DBABL_DISABLE_DEPRECATED -DGSEAL_ENABLE -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -O2 -march=native -pipe -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definition -Wmissing-format-attribute -Wformat-security -MT libcolor_selector_cmyk_la-color-selector-cmyk.lo -MD -MP -MF .deps/libcolor_selector_cmyk_la-color-selector-cmyk.Tpo -c color-selector-cmyk.c -fPIC -DPIC -o .libs/libcolor_selector_cmyk_la-color-selector-cmyk.o color-selector-cmyk.c: In function 'colorsel_cmyk_adj_update': color-selector-cmyk.c:230: error: 'GtkAdjustment' has no member named 'value' color-selector-cmyk.c:233: error: 'GtkAdjustment' has no member named 'value' color-selector-cmyk.c:236: error: 'GtkAdjustment' has no member named 'value' color-selector-cmyk.c:239: error: 'GtkAdjustment' has no member named 'value' color-selector-cmyk.c: In function 'colorsel_cmyk_pullout_update': color-selector-cmyk.c:257: error: 'GtkAdjustment' has no member named 'value' make[2]: *** [libcolor_selector_cmyk_la-color-selector-cmyk.lo] Error 1 make[2]: Leaving directory `/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/modules' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999' make: *** [all] Error 2 if you pass --disable-gtk-doc to autogen.sh it will go on. Probably we just need to add the doc flag check in a correct way. with this changes, it will compile: --- /var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/modules/color-selector-cmyk.c 2009-11-04 17:37:24.725382043 +0100 +++ patched-color-selector-cmyk.c 2009-12-16 13:37:03.000000000 +0100 @@ -219,24 +219,26 @@ { GimpColorSelector *selector = GIMP_COLOR_SELECTOR (module); gint i; + gdouble value; for (i = 0; i < 4; i++) if (module->adj[i] == adj) break; + value = gtk_adjustment_get_value (adj) / 100.0; switch (i) { case 0: - module->cmyk.c = adj->value / 100.0; + module->cmyk.c = value; break; case 1: - module->cmyk.m = adj->value / 100.0; + module->cmyk.m = value; break; case 2: - module->cmyk.y = adj->value / 100.0; + module->cmyk.y = value; break; case 3: - module->cmyk.k = adj->value / 100.0; + module->cmyk.k = value; break; default: return; @@ -253,8 +255,10 @@ ColorselCmyk *module) { GimpColorSelector *selector = GIMP_COLOR_SELECTOR (module); + gdouble value; + value = gtk_adjustment_get_value (adj) / 100.0; - module->pullout = adj->value / 100.0; + module->pullout = value; gimp_color_selector_set_color (selector, &selector->rgb, &selector->hsv); } (In reply to comment #4) thanks, it compiles fine with the patch. working ebuild is now in arcon overlay Created attachment 213241 [details, diff]
patch to fix compilation
Correct flag is passed: '--disable-gtk-doc', you can see it in error message. It fails anyway. (In reply to comment #4) > with this changes, it will compile: the patch no longer works unfortunately :( orginal bug with gtk-doc is also still unfixed Created attachment 224563 [details]
media-gfx/gimp-9999.ebuild
I've managed to install it couple of weeks ago with this ebuild, I've forced --disable-gtk-doc flag, and a couple of other things. Still I don't know if recent changes broke it again, so feel free to test it and see if it's working. Mind that you'll need git versions of gegl and babl for the configure to finish successfully.
autogen.sh has to be invocated with --disable-gtk-doc : ./autogen.sh --disable-gtk-doc during src_prepare if you want to build gimp-9999 without gtk-doc installed. ATM, (commit ba9b0c12c7f3f16e43cb83a6740cdb3c7c9345c0), gimp-9999 compiles fine against gegl-0.1.2 and babl-0.1.2, with USE="alsa dbus exif hal jpeg mmx mng pdf png python smp sse svg tiff -aalib -curl -debug -doc -gnome -lcms -webkit -wmf", ~amd64. The ebuild needs to have two lines in RDEPEND for >=media-libs/babl-0.1.2 and >=media-libs/gegl-0.1.2 dependences. |