Summary: | gome-base/gdm-2.28.1-r1 does not depend on hal | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Florian Scandella <flo> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | nicolasbock |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugzilla.gnome.org/show_bug.cgi?id=593787 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 288249 | ||
Attachments: | Remove remaining Hal-bits from gdm-2.28 |
Description
Florian Scandella
2009-11-30 16:10:32 UTC
that is not a valid test nor argument. what do you mean? if it compiles without hal, it means autoconf is not checking for it. just found this ubuntu bug report: https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/418981 added info ... (In reply to comment #2) > what do you mean? if it compiles without hal, it means autoconf is not checking > for it. > just found this ubuntu bug report: > https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/418981 > But, as I can read in ebuild, hal is in RDEPEND, not in DEPEND, then, it can build without it but maybe some feature is damaged From what I can see, all the code that actually uses hal is commented out. Found an upstream bug that cleans up the remaining hal-related code from gdm master: https://bugzilla.gnome.org/show_bug.cgi?id=593787 We should be good with just removing the dep (though that will probably trigger "could not connect to hal" warnings). Best to backport the patch. Will try to get to this if nobody beats me to it. Created attachment 220185 [details, diff] Remove remaining Hal-bits from gdm-2.28 (In reply to comment #5) > We should be good with just removing the dep (though that will probably trigger > "could not connect to hal" warnings). Best to backport the patch. Will try to > get to this if nobody beats me to it. > Is this patch close enough? I've added a similar path to portage with 2.28.2-r1, thanks for reporting (In reply to comment #7) > I've added a similar path to portage with 2.28.2-r1, thanks for reporting > I like your take on using rm.:-) Thanks for fixing! |