Bug 294675 – app-portage/gentoolkit: Extra letter in eclean output

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Richard Li 2009-11-26 08:06:09 UTC]

Look at the following outputs made by "eclean-dist -di":

 * Building file list for distfiles cleaning...
 * Cleaning distfiles...
 [  874L B ] brainfuck-syntax-1.0.1.tar.bz2
 > Do you want to delete this file? [Y/n/a]:

I guess the letter "L" in "[   874L B]" should be removed. This happens only for files less than 1000 bytes.

I use gentoolkit-0.3.0_rc7 and python-2.6.2-r2

[Comment 1 Richard Li 2009-11-26 08:08:58 UTC]

Created attachment 211221 [details, diff]
Patch

It can be fixed by simply forcing the first argument to fpformat.fix to be of float type.

[Comment 2 Brian Dolbec (RETIRED) 2010-03-06 19:51:56 UTC]

Ok, I tested this on my system and it worked for all 3 versions _rc9, dev trunk sources and the eclean re-write.  Then I realized it was being passed a long integer. I did a little testing, was able to duplicate it passing a long to it.

A little more investigation revealed that fpformat is deprecated in python-2.6 and removed in 3.0 so I converted to using string methods which handle long integers properly.

Thank you for the bug report and patch.  Even though I did not use it, it made it easier to fix.

...you should see this change in -0.3.0_rc10

brian@big_daddy ~/Dev/genscripts/branches/gentoolkit_eclean $ svn commit pym/gentoolkit/eclean/output.py
Authentication realm: <https://genscripts.googlecode.com:443> Google Code Subversion Repository
Password for 'brian.dolbec': 
Sending        pym/gentoolkit/eclean/output.py
Transmitting file data .
Committed revision 268.

[Comment 3 Christian Ruppert (idl0r) 2010-04-06 10:16:47 UTC]

This bug has been fixed in app-portage/gentoolkit-0.3.0_rc10, thanks for reporting this issue.