Bug 292531 – app-admin/conky-1.7.2-r2: error in ebuild makes it impossible to build without x11 support

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jon Bramley 2009-11-09 14:50:39 UTC]

In the current ebuild, there is the following segment:

    if use X; then
        myconf="--enable-x11 --enable-double-buffer --enable-xdamage"
        myconf="${myconf} --enable-own-window"
        myconf="${myconf} $(use_enable imlib imlib2) $(use_enable lua-cairo)"
        myconf="${myconf} $(use_enable lua-imlib lua-imlib2)"
        myconf="${myconf}  $(use_enable nvidia) $(use_enable truetype xft)"
    else
        myconf="--disable-x11 --disable-own-window"
        myconf="--disable-imlib --disable-lua-cairo --disable-lua-imlib"
        myconf="--disable-nvidia --disable-xft"
    fi

As you can see, in the case of "-X", the myconf variable is overwritten twice, so the --disable-x11 flag (and the other 4) doesn't make it to the call to ./configure.

Reproducible: Always

Steps to Reproduce:
1. Attempt to build app-admin/conky-1.7.2-r2 without the X useflag
2.
3.

Actual Results:  
conky is compiled with X11 support

Expected Results:  
conky is compiled without X11 support

[Comment 1 Jon Bramley 2009-11-09 14:51:44 UTC]

Created attachment 209747 [details]
ebuild that correctly adheres to -X use flag

Attached a working ebuild.

[Comment 2 Daniel Pielmeier 2009-11-09 16:42:34 UTC]

Thanks for spotting this, how could I forget about this. Especially because I did the part above like it is supposed to be :) Will fix this in a few hours.

PS: Next time if you attach a fix, please provide a unified diff, this make life much more easier for us. Here the mistake is quite obvious, but sometimes it is trickier, so actually seeing the differences helps a lot.

[Comment 3 Daniel Pielmeier 2009-11-09 18:46:22 UTC]

I have fixed this issue without a revision bump. The update should be available in a few hours.