Summary: | mail-mta/postfix-2.6.5 init script handles multiple instances incorrectly | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michael Orlitzky <mjo> |
Component: | Current packages | Assignee: | Net-Mail Packages <net-mail+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | artur, fedux, gibgibon, tom |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 316577 | ||
Attachments: | Patch for builtin multi-instance support |
Description
Michael Orlitzky
2009-11-07 07:33:54 UTC
Michael, Did you have a patch available? Created attachment 226479 [details, diff]
Patch for builtin multi-instance support
This is the patch I'm running against the init script. Unfortunately, it's not backwards compatible. To move away from the old-style multiple instances, users will have to update a few things manually:
1. Stop everything.
2. Rename the secondary instance config directories so that they don't contain periods. At least when I went through the process, Postfix would barf on instances named e.g. postfix.alt, which was the documented name in previous Gentoo releases. postfix-alt, with a hyphen, works.
3. Import the old instance into the new framework. This is outlined in the MULTI_INSTANCE_README.
4. There is an implied step #4, "fix everything that went wrong." The postmulti import makes some assumptions about your layout. If they weren't correct, main.cf will probably need to be updated. At this point, you should be able to start the instance manually.
5. Optionally enable the new instance and/or add it to a group.
However, it should be possible to make the init script backwards-compatible (completely untested of course):
If CONF_DIR is simply /etc/postfix, avoid passing -c CONF_DIR to all of the invocations in the init script. This works when there is a single instance, since /etc/postfix is the default, and it also works when there are multiple new-style instances, because Postfix handles them automatically.
If CONF_DIR is not /etc/postfix, then the user is using an old-style (Gentoo) multiple instance, and we can safely pass CONF_DIR to all of the commands. Possibly spit out a warning that the user should update his config someday.
As the "new" multiple instances support in Postfix itself is backwards compatible to our "old" multiple instances support i'd like to keep it that way for our 2.6.x series ebuilds. For the 2.7.x series (which i'll bump to today or tomorrow) i'll include the proposed patch and will submit a news item for review so users get a chance to know about this change before upgrading. +*postfix-2.9_pre20110605 (15 Jun 2011) + + 15 Jun 2011; Eray Aslan <eras@gentoo.org> +postfix-2.9_pre20110605.ebuild, + +files/postfix.rc6.2.6: + Version bump. Add multi instance support. + Only lightly tested. Please test if you can. As a side note, the postmulti upgrade warning in init script gets old quickly. Probably best to remove it. I don't have any old multi-instance boxes that need converting anymore, but it seems to work fine on the ones that I already switched to the new multi-instance style. Fixed in >=postfix-2.9.0. Closing. |