Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 291797

Summary: net-libs/xulrunner-1.9.1* ebuilds apply patch in wrong directory
Product: Gentoo Linux Reporter: Chris Coleman <chrsclmn>
Component: New packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: VERIFIED FIXED    
Severity: normal Keywords: InVCS
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Chris Coleman 2009-11-04 02:09:44 UTC
This is in xulrunner-1.9.1.3.ebuild, xulrunner-1.9.1.3-r1.ebuild and xulrunner-1.9.1.4.ebuild:

----------------------------------------------------------------------------
eautoreconf

cd js/src
eautoreconf

# Patch in support to reset all LANG variables to C
# Do NOT add to patchset as it must be applied after eautoreconf
epatch "${FILESDIR}/000_flex-configure-LANG.patch"
----------------------------------------------------------------------------

As you can see, 000_flex-configure-LANG.patch is being applied in ${S}/js/src instead of ${S} as in previous ebuilds.

That patch says it fixes bug #103483.

I think the previous ebuilds were correct and that the patch should be applied to the top level configure script, not just the one in ${S}/js/src.
Comment 1 Chris Coleman 2009-11-04 02:29:13 UTC
The same is also in www-client/mozilla-firefox-3.5.3.ebuild, www-client/mozilla-firefox-3.5.3-r1.ebuild and www-client/mozilla-firefox-3.5.4.ebuild.
Comment 2 Jory A. Pratt gentoo-dev 2009-11-04 14:17:03 UTC
Fixed in xulrunner-1.9.1.4/firefox-3.5.4 thanks for reporting.
Comment 3 Jory A. Pratt gentoo-dev 2009-11-04 14:20:11 UTC
I have also fixed up icecat which was applying patch in wrong directory as well.