Bug 290917

Summary:	[EBUILD] net-misc/gofish-1.1 enhanced ebuild
Product:	Gentoo Linux	Reporter:	Ivan Anishchuk <matimatik>
Component:	New packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	enhancement	Keywords:	EBUILD, InVCS
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://sourceforge.net/projects/gofish
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	gofish-1.1.ebuild gofish-1.1.ebuild.patch gofish-1.1.ebuild gofish-1.1.ebuild.patch gofish-1.1.ebuild gofish-1.1.ebuild.patch proper gofish-1.1.ebuild.patch

Description Ivan Anishchuk 2009-10-28 18:54:52 UTC

New ebuild for net-misc/gofish with several enhancement and fixes. See ebuild or diff for details

Reproducible: Always

Comment 1 Ivan Anishchuk 2009-10-28 19:01:12 UTC

Created attachment 208567 [details]
gofish-1.1.ebuild

this is it

Comment 2 Ivan Anishchuk 2009-10-28 19:03:11 UTC

Created attachment 208568 [details, diff]
gofish-1.1.ebuild.patch

diff for easy review

Comment 3 Ivan Anishchuk 2009-10-29 13:49:49 UTC

Created attachment 208635 [details]
gofish-1.1.ebuild

changing ownership was a bad idea :(

Comment 4 Ivan Anishchuk 2009-10-29 13:51:33 UTC

Created attachment 208636 [details, diff]
gofish-1.1.ebuild.patch

Comment 5 Víctor Ostorga (RETIRED) gentoo-dev

2009-11-08 15:58:16 UTC

First, thanks for the ebuild.
Second , why do you want to use /var/lib/gopher instead of /var/gopher and /var/lib/www instead of /var/www ? 
Take into account users must never need to modify files in /var/lib to configure a package's operation, as stated in FHS[1]

[1]http://www.pathname.com/fhs/pub/fhs-2.3.html#VARLIBVARIABLESTATEINFORMATION

Comment 6 Ivan Anishchuk 2009-11-08 18:58:12 UTC

Created attachment 209646 [details]
gofish-1.1.ebuild

(In reply to comment #5)
Ok, I was wrong. What about this?

Comment 7 Ivan Anishchuk 2009-11-08 18:59:24 UTC

Created attachment 209649 [details, diff]
gofish-1.1.ebuild.patch

diff

Comment 8 Ivan Anishchuk 2009-11-08 19:02:25 UTC

Created attachment 209653 [details, diff]
proper gofish-1.1.ebuild.patch

sorry i have filed wrong diff :(

Comment 9 Michael Weber (RETIRED) gentoo-dev

2011-04-06 21:41:28 UTC

+  06 Apr 2011; Michael Weber <xmw@gentoo.org> +gofish-1.1-r1.ebuild,
+  metadata.xml:
+  Taking maint. Removed explicit uid/gid in ebuild/config (thanks to
+  oliver@schinagl.nl on bug 268678). Some cleanups and added docs (thanks to
+  matimatik@lavabit.com on bug 290917)