Bug 289462

Summary:	gnome-base/gnome-applets: upstream patch for solving find function not working with multiple matches
Product:	Gentoo Linux	Reporter:	Pacho Ramos <pacho>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED UPSTREAM
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugzilla.gnome.org/show_bug.cgi?id=621476
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	gnome-applets-2.26.3-weather.patch

Description Pacho Ramos gentoo-dev

2009-10-17 10:10:55 UTC

At least the patch from bug:
https://bugzilla.gnome.org/show_bug.cgi?id=424639

got comitted by upstream, it works fine for me with 2.26 (and also 2.24 and...), you can reproduce the problem simply searching "Barcelona" and seen that it cannot find more than one location

Thanks a lot

Reproducible: Always

Comment 1 Pacho Ramos gentoo-dev

2009-10-17 10:11:09 UTC

Created attachment 207386 [details, diff]
gnome-applets-2.26.3-weather.patch

Comment 2 Pacho Ramos gentoo-dev

2010-01-05 19:29:47 UTC

Do you let me commit this for gnome-applet-2.26.3-r1 ? (maybe it would also be needed for 2.28 :-/, I need to check it)

Thanks a lot

Comment 3 Nirbheek Chauhan (RETIRED) gentoo-dev

2010-01-06 02:46:06 UTC

Accepted upstream, and looks OK to me. I suppose that as long as you follow gnome practices w.r.t patch addition[1] you can add it.

1. http://dev.gentoo.org/~vapier/clean-patches + Add one-line comment in ebuild about why the patch was added, with the bug number

Comment 4 Romain Perier (RETIRED) gentoo-dev

2010-01-06 09:37:05 UTC

(In reply to comment #3)
> Accepted upstream, and looks OK to me. I suppose that as long as you follow
> gnome practices w.r.t patch addition[1] you can add it.
> 
> 1. http://dev.gentoo.org/~vapier/clean-patches + Add one-line comment in ebuild
> about why the patch was added, with the bug number
> 

Seriously this patch is fine, there is a comment, a bug reference, an author, a subject... it's good enough, imho.
A diffstat would be just useless because there is just one file to diff.
Usually patches imported from cgit are correct.
 
Btw, this is not a work made by picasso, but just a patch ;)

Comment 5 Pacho Ramos gentoo-dev

2010-01-07 20:45:23 UTC

I am really surprised, but the patch no longer work :-O

I am sure that this fixed things when I reported this, but, today, I have retried it before commiting and seems that it doesn't solve the bug :-(