Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 289401

Summary: Convert eselect-python to use automake
Product: Gentoo Linux Reporter: Jonathan Callen (RETIRED) <jcallen>
Component: [OLD] Core systemAssignee: Python Gentoo Team <python>
Status: RESOLVED FIXED    
Severity: normal CC: binki, ferret-bgo, jcallen, tommy
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: convert to automake

Description Jonathan Callen (RETIRED) gentoo-dev 2009-10-16 22:06:11 UTC
This patch converts eselect-python to use automake, fixing a couple of issues with builds on odd systems, and, incidentally, should fix the issue with ASFLAGS.
Comment 1 Jonathan Callen (RETIRED) gentoo-dev 2009-10-16 22:09:25 UTC
Created attachment 207367 [details, diff]
convert to automake

Before applying this patch, you should run:
    svn mv python.eselect python.eselect.in
    svn rm Makefile.in

After applying, run
    svn add Makefile.am
Comment 2 ferret 2009-11-30 16:05:19 UTC
Please apply this patch.  eselect-python doesn't compile on as 32-bit our multilib setup at the moment, because we set ASFLAGS globally, and eselect-python passes it to gcc as-is.

As stated in the man page:

########
  If you are invoking as via the GNU C compiler, you can use the -Wa option to pass arguments through to the assembler. The assembler arguments must be separated from each other (and the -Wa) by commas. For example:

  gcc -c -g -O -Wa,-alh,-L file.c
########

So eselect-python's Makefile.in either needs to parse ASFLAGS and change spaces to commas, or more simply, be converted to use automake.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-12-01 08:13:18 UTC
Automake creates unnecessarily overcomplicated Makefile.in files.
I will rather just remove using of ASFLAGS.
Comment 4 Thomas Sachau gentoo-dev 2009-12-20 14:17:51 UTC
(In reply to comment #3)
> Automake creates unnecessarily overcomplicated Makefile.in files.
> I will rather just remove using of ASFLAGS.
> 

This was now over 2 weeks ago, any progress?
Comment 5 Mike Gilbert gentoo-dev 2012-05-19 20:39:16 UTC
eselect-python-20111108 uses automake.