Summary: | Add daemontools support to init script for samba | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mark Francis <mark> |
Component: | Current packages | Assignee: | Gentoo's SAMBA Team <samba> |
Status: | RESOLVED NEEDINFO | ||
Severity: | enhancement | CC: | azarah, hhg, seemant |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 28294 | ||
Bug Blocks: | |||
Attachments: |
Patch for init.d script to support daemontools if installed
daemontools run script for nmbd daemontools run script for smbd logger /var/daemontools/mnbd/run /var/daemontools/nmbd/log/run samba-2.2.8a.ebuild patch |
Description
Mark Francis
2003-09-16 23:05:51 UTC
Created attachment 17846 [details, diff]
Patch for init.d script to support daemontools if installed
Created attachment 17847 [details]
daemontools run script for nmbd
Created attachment 17848 [details]
daemontools run script for smbd logger
Previous entry is actually the run file for smbd, not nmbd.
Created attachment 17849 [details]
/var/daemontools/mnbd/run
Created attachment 17850 [details]
/var/daemontools/nmbd/log/run
Created attachment 17871 [details, diff]
samba-2.2.8a.ebuild patch
Ok, nice job. Works fine for me. Here's a
patch for the 2.2.8a ebuild that installs
the necessary files. It's pretty simple
so adding it to the other ebuilds is trivial
as well. I'm leaving it up to woodchip to
decide where he wants this :-).
Yes, I forgot, take notice of the filesnames in the 2.2.8a patch, they're the following: files/smbd-run files/smbd-log-run files/nmbd-run files/nmbd-log-run ok. incidentally i made the files/config-svc-smbd+nmbd scriptlet for this purpose a couple years ago. i'll need to have another look at this though. Look at my comment in: http://bugs.gentoo.org/show_bug.cgi?id=28941 I do not like hacking the same thing in 20 scripts. New toplevel directories are not supposed to be created in /var. We might consider moving /var/empty (SSH privsep) as well just to be consistent. A supervised initscript can live in it's own file, like init.d/samba-svc. Also, I've already kept supervised init files in the net-fs/samba/files directory for quite some time now. See files/samba-svc and files/config-svc-smbd+nmbd. I might just add these into the ebuild again; I never removed them from CVS because I figured it might be requested in the future, like now. Just 'source files/config-svc-smbd+nmbd' in src_intall, and then call the function config_install. Two lines, everything is already there. I notice the stuff in CVS and your stuff are quite different, I dont which are "better" or what right now. Is there still interest in this ? Any patches for the current version of samba ? closing it now, due to lack of new feedback .. if still interest, feel free to reopen the bug. |