Bug 288575 – dev-util/git-1.6.4.4 test suite fails on alpha

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Tobias Klausmann (RETIRED) 2009-10-11 16:03:07 UTC]

Test suite fails on alpha:
*** t3700-add.sh ***
[...]
* FAIL 21: git add should fail atomically upon an unreadable file
* FAIL 22: git add --ignore-errors
* FAIL 23: git add (add.ignore-errors)
* FAIL 24: git add (add.ignore-errors = false)
* FAIL 25: --no-ignore-errors overrides config
[...]

# emerge --info
Portage 2.1.6.13 (default/linux/alpha/2008.0, gcc-4.3.4, glibc-2.9_p20081201-r3, 2.6.31.3 alpha)                                                                
=================================================================               
System uname: Linux-2.6.31.3-alpha-EV68AL-with-gentoo-2.0.1                     
Timestamp of tree: Sun, 11 Oct 2009 13:45:02 +0000                              
distcc 3.1 alpha-unknown-linux-gnu [enabled]                                    
app-shells/bash:     4.0_p28                                                    
dev-lang/python:     2.6.2-r1, 3.1.1                                            
dev-python/pycrypto: 2.0.1-r8                                                   
dev-util/cmake:      2.6.4-r2                                                   
sys-apps/baselayout: 2.0.1                                                      
sys-apps/openrc:     0.4.3-r3                                                   
sys-apps/sandbox:    2.1                                                        
sys-devel/autoconf:  2.13, 2.63-r1                                              
sys-devel/automake:  1.9.6-r2, 1.10.2, 1.11                                     
sys-devel/binutils:  2.19.1-r1                                                  
sys-devel/gcc-config: 1.4.1                                                     
sys-devel/libtool:   2.2.6a                                                     
virtual/os-headers:  2.6.30-r1                                                  
ACCEPT_KEYWORDS="alpha ~alpha"                                                  
CBUILD="alpha-unknown-linux-gnu"                                                
CFLAGS="-mieee -pipe -O2 -mcpu=ev67"                                            
CHOST="alpha-unknown-linux-gnu"                                                 
CONFIG_PROTECT="/etc /var/qmail/alias /var/qmail/control"                       
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"                             
CXXFLAGS="-mieee -pipe -O2 -mcpu=ev67"                                          
DISTDIR="/usr/portage/distfiles"                                                
FEATURES="distcc distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans usepkg userfetch"                                    
GENTOO_MIRRORS="http://gentoo.tiscali.nl/ http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/"                                                                
LDFLAGS="-Wl,-O1"                                                               
MAKEOPTS="-j2"                                                                  
PKGDIR="/usr/portage/packages"                                                  
PORTAGE_CONFIGROOT="/"                                                          
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"                                                  
PORTAGE_TMPDIR="/var/tmp"                                                       
PORTDIR="/usr/portage"                                                          
PORTDIR_OVERLAY="/usr/local/portage"                                            
SYNC="rsync://rsync5.de.gentoo.org/gentoo-portage"                              
USE="X acl alpha alsa apache2 audiofile bash-completion berkdb bmp bzip2 calendar cdparanoia cdr cli cracklib crypt dio dri encode ethereal exif ffmpeg fftw firefox flac fortran ftp gdbm gpm iconv imlib2 isdnlog jpeg kdeenablefinal libcaca lua mad matroska mmap mng modules moznocompose moznoirc moznomail mozsvg mpeg mudflap ncurses network-cron nls nptl nptlonly offensive ogg openmp pam pcre pdflib perl png pnm ppds pppd python rar readline recode reflection session sharedmem sockets sox spl ssl svg sysfs szip tcpd tetex theora truetype unicode usb v4l v4l2 vcd vidix vim vim-pager vlm vorbis xcb xorg xosd xpm xvid zlib" ALSA_CARDS="ali5451 als4000 bt87x ca0106 cmipci emu10k1 ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 maestro3 trident usb-audio via82xx ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="vga glint mga nvidia vesa r128 "
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

I'll also attach the build log etc

[Comment 1 Tobias Klausmann (RETIRED) 2009-10-11 16:04:08 UTC]

Created attachment 206778 [details]
build log

[Comment 2 Tobias Klausmann (RETIRED) 2009-10-11 16:17:39 UTC]

Created attachment 206780 [details]
t3700 result file #1

[Comment 3 Tobias Klausmann (RETIRED) 2009-10-11 16:19:17 UTC]

Created attachment 206782 [details]
t3700 result file #2

[Comment 4 Robin Johnson 2009-10-11 16:56:59 UTC]

please retest with FEATURES=userpriv

[Comment 5 Tobias Klausmann (RETIRED) 2009-10-11 17:26:55 UTC]

With FEATURES=userpriv, the test suite passes. Maybe the ebuild should check&warn if it isn't set? The way distcc's pump mode works, all people who use it must currently set -userpriv (and -usersandbox). I've talekd to zmedico about that but a fix/feature for that won't be around for a while now.

Feel free to close as fixed if you think the test/warn isn't necessary. I'll stabilize dev-util/git-1.6.4.4 in a few moments.

[Comment 6 Robin Johnson 2009-10-11 17:32:06 UTC]

We do try to disable tests that break under FEATURES=-userpriv, and there IS a warning that is already displayed (it's in your build-log), this is just one that got missed.

Is t3700 the only testcase that fails for you?

[Comment 7 Tobias Klausmann (RETIRED) 2009-10-11 18:49:56 UTC]

(In reply to comment #6)
> We do try to disable tests that break under FEATURES=-userpriv, and there IS a
> warning that is already displayed (it's in your build-log), this is just one
> that got missed.

Whoops, I should've seen that. My bad, then.

> Is t3700 the only testcase that fails for you?

The test suite terminates right after that, so I don't know if it's the only one that breaks with -userpriv. With user privileges, the whole test suite passes.

[Comment 8 Robin Johnson 2009-10-11 18:54:58 UTC]

if you look at the src_test block, there's two tests already disabled for -userpriv:
t0004, t1004
just add in t3700 there for yourself.
it doesn't fail here, but this isn't the first time i've seen an arch-specific test.

[Comment 9 Tobias Klausmann (RETIRED) 2009-10-22 21:52:06 UTC]

I've done some more (and deeper) testing today and foudn that not only test 3700 has the uid-0 problem, but test 7300 (sic), too. So I've added both to the corresponding section in the ebuild. Feel free to revert if I've SNAFU'd anything. 

Closing since the original issue is dealt with.

[Comment 10 Robin Johnson 2009-10-22 22:27:25 UTC]

thanks.