Bug 28733 – xmule 1.6.0a doesn't rehash files properly

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michal Januszewski (RETIRED) 2003-09-14 15:03:26 UTC]

When mtime from the .met file and filesystem's mtime of the partfile do not
match, xmule rehashes completed parts of the downloaded file to check if
everything is alright with it. The problem is, xmule 1.6.0a doesn't do that - it
says it is rehashing while it isn't. This leads to marking all parts of the file
as 'wrong' (ie. to-download) and to unnecessary redownload of data.

This bug is caused by incorrect splitting files' fullname into filename and path
components and is fixed by the attached patch.

[Comment 1 Michal Januszewski (RETIRED) 2003-09-14 15:04:21 UTC]

Created attachment 17722 [details, diff]
a patch that fixes the rehashing problem

[Comment 2 Rainer Größlinger (RETIRED) 2003-09-20 09:10:53 UTC]

when I searched around at the xmule forums I read a post by a xmule developer who said that this was already fixed in their cvs.

They don't use sourceforge cvs anymore and I don't know where their current cvs repository is, but is this the same patch they used?
Although this patch shouldn't raise new problems as it's straight forward :)

[Comment 3 Michal Januszewski (RETIRED) 2003-09-20 11:28:35 UTC]

No, this is a patch that I wrote when I got really angry when xmule rehashed a file that was almost finished and 'detected' only 34 bytes of downloaded data ;>
I didn't know the xmule devs had already fixed it. I normally look at a project's bugzilla, but I rarely check the forums (perhaps I will have to start doing so..). Anyway, since, as you have already noted, this patch is really simple, I guess it could be introduced to the ebuild for the time being. When a new version of xmule comes out, they should have it fixed by themselves. 

[Comment 4 Rainer Größlinger (RETIRED) 2003-09-20 11:58:39 UTC]

committed.

thank you for submitting the patch !