| Summary: | dev-libs/elfutils-0.143 fails to configure when CONFIG_SHELL is not bash | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Harald van Dijk (RETIRED) <truedfx> |
| Component: | [OLD] Unspecified | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
elfutils-0.143-configure-bashisms.patch
elfutils-config-shell.patch |
||
it doesn't think much of this either: 5497 # Round up to the next release API (x.y) version. 5498 eu_version=$[($eu_version + 999) / 1000] Created attachment 205743 [details, diff]
elfutils-0.143-configure-bashisms.patch
are you setting CONFIG_SHELL manually ? autoconf should be smart and find /bin/bash and then use it rather than /bin/sh. Yes and no. Yes, I am setting CONFIG_SHELL manually, but no, autoconf does not force bash, and configure scripts are supposed to work with any POSIX shell. dash is missing $LINENO support, which is why configure prefers bash over dash, but that is the only reason. i dont see the point in supporting people who force CONFIG_SHELL in their env. if you can convince upstream to fix their stuff, that'd be great, but i dont really have hope in such things considering who the upstream maintainer is. so if the only issue is people doing pointless stuff, then no need to change the elfutils ebuild. In case I wasn't clear: if I hack dash to support LINENO (in a broken way but enough to pass the configure check), then configure uses dash _even if I do not set CONFIG_SHELL_. you should hack in support for substring replacement too at any rate, you can try posting the patch upstream now that it seems to have a real project: https://fedorahosted.org/mailman/listinfo/elfutils-devel (In reply to comment #7) > you should hack in support for substring replacement too That's not part of POSIX, so even if dash were made to support that, sh scripts still shouldn't rely on it. I'll probably send Ryan's patch (thanks btw) to the list later today or tomorrow. Created attachment 211001 [details, diff]
elfutils-config-shell.patch
The attached patch has been applied upstream (on the portability branch -- I don't know if that means it will be part of the next release), can it be added to the ebuild as well?
feel free to apply to the configure script ... i dont want to rerun autotools because of such trivial things Thanks. Actually trying it shows that the commit has removed the ;; causing a syntax error in every shell, even bash. Re-adding the ;; qualifies as obvious in my opinion, but I'll wait to see if upstream changes anything else when fixing that. Fixed. |
checking for msgfmt... /usr/bin/msgfmt checking for gmsgfmt... /usr/bin/gmsgfmt checking for xgettext... /usr/bin/xgettext checking for msgmerge... /usr/bin/msgmerge ./configure.lineno: 5467: Bad substitution !!! Please attach the following file when seeking support: !!! /var/tmp/portage/dev-libs/elfutils-0.143/work/elfutils-0.143/config.log * * ERROR: dev-libs/elfutils-0.143 failed. * Call stack: * ebuild.sh, line 49: Called src_compile * environment, line 2574: Called econf '--enable-nls' '--program-prefix=eu-' '--with-zlib' '--with-bzlib' '--without-lzma' * ebuild.sh, line 536: Called die * The specific snippet of code: * die "econf failed" * The die message: * econf failed * * If you need support, post the topmost build error, and the call stack if relevant. * A complete build log is located at '/var/tmp/portage/dev-libs/elfutils-0.143/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/dev-libs/elfutils-0.143/temp/environment'. * $ sed -ne 5461,5467p /var/tmp/portage/dev-libs/elfutils-0.143/work/elfutils-0.143/configure.lineno # 1.234<whatever> -> 1234<whatever> case "$PACKAGE_VERSION" in [0-9].*) eu_version="${PACKAGE_VERSION/./}" ;; *) { { $as_echo "$as_me:5464: error: confused by version number '$PACKAGE_VERSION'" >&5 $as_echo "$as_me: error: confused by version number '$PACKAGE_VERSION'" >&2;} { (exit 1); exit 1; }; } ;; esac ${a/b/c} is non-standard and not supported by dash.