Bug 286299

Summary:	x11-terms/xterm ROOT ping pong.
Product:	Gentoo Linux	Reporter:	solar (RETIRED) <solar>
Component:	New packages	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	dickey, embedded, ssuominen
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description solar (RETIRED) gentoo-dev

2009-09-24 20:50:51 UTC

Hey we keep going back and forth here. I'll fix xterm. Somebody will come along and un-fix it. I'll explain in detail why it is the way it is. Later it gets removed.

So I'll do my best to explain the problem and hopefully the fix will be left in place this time.

When --x-libraries= is passed to configure it tells it where to look for the libs it will "link" to. So if you are for example cross compiling. It will never work if you pass --x-libraries=/usr/lib/ because it will try to link the host libs with the cross compiled bins. ROOT is where the cross-compiled libs live, thus we must always use --x-libraries=$ROOT/usr/$(get_libdir). It seems strage to many devs to see ROOT in a src_* phase. But this is required.
As $ROOT defaults to / or "" when native building. This will have no ill effects on the xterm pkg or runtime/linking behavior for anybody.

In this case it's xterm-248 that is failing. A little hand editing of the ebuild shows how to get xterm to not fail.

wizdev tmp # grep '$ './configure config.log.xterm.* 

(FAILS)
config.log.xterm.fail:  $ ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=armv7a-softfloat-linux-gnueabi --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/etc --x-libraries=/usr/lib --disable-full-tgetent --with-app-defaults=/usr/share/X11/app-defaults --disable-setuid --disable-setgid --with-utempter --with-x --without-Xaw3d --disable-imake --enable-256-color --enable-broken-osc --enable-broken-st --enable-freetype --enable-i18n --enable-load-vt-fonts --enable-logging --disable-toolbar --disable-mini-luit --disable-luit --enable-wide-chars --enable-dabbrev --enable-warnings

(WORKS)
config.log.xterm.good:  $ ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=armv7a-softfloat-linux-gnueabi --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/etc --x-libraries=/usr/armv7a-softfloat-linux-gnueabi//usr/lib --disable-full-tgetent --with-app-defaults=/usr/share/X11/app-defaults --disable-setuid --disable-setgid --with-utempter --with-x --without-Xaw3d --disable-imake --enable-256-color --enable-broken-osc --enable-broken-st --enable-freetype --enable-i18n --enable-load-vt-fonts --enable-logging --disable-toolbar --disable-mini-luit --disable-luit --enable-wide-chars --enable-dabbrev --enable-warnings


I do not think this is a bug for upstream. It's just how it works.

Comment 1 Rémi Cardona (RETIRED) gentoo-dev

2009-09-25 06:51:57 UTC

Couldn't xterm use pkg-config to check for X libs and then fallback to whatever scheme it currently uses?

Thomas, what say you?

Thanks

Comment 2 Thomas Dickey 2009-09-27 14:34:24 UTC

Would pkg-config have more reliable information?
I have macros which I use for the odd nonstandard
library such as Xft.

Comment 3 Rémi Cardona (RETIRED) gentoo-dev

2009-09-27 17:00:02 UTC

(In reply to comment #2)
> Would pkg-config have more reliable information?
> I have macros which I use for the odd nonstandard
> library such as Xft.

Just take a look at all the FDo-hosted apps, all of them use pkg-config and have dropped the old macros.

As for Xft, I don't see what's non-standard about it : here's what "pkg-config --cflags --libs xft" returns on my system :

-I/usr/include/freetype2  -lXft -lXrender -lfontconfig -lfreetype -lX11

Most Gnome apps that do custom X11 wizardry use pkg-config to find X libs, and usually fall back to the old X macros. Maybe that'd be a good solution for xterm if support for _really_ old/odd systems is important to you.

Slightly OT, is there any reason (legal, historical, practical, ...) why xterm isn't hosted in a git repo at FDo either?

Cheers

Comment 4 Thomas Dickey 2009-09-28 09:16:26 UTC

regarding git - call it historical.

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2009-10-03 11:58:43 UTC

249 in tree with the $ROOT hack again, mentioned this bug in ChangeLog now so it won't get lost. Closing as UPSTREAM, please switch to using pkg-config.

Comment 6 Thomas Dickey 2009-10-03 13:02:18 UTC

I did add a to-do item for this; implementing and testing it
in the timeframe for #249 would have delayed more urgent fixes.