Summary: | >=sys-apps/shadow-4.1.3.1 reset LC_ALL, LANG, LANGUAGE when using "su" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Fabio Erculiani (RETIRED) <lxnay> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | help, pacho |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | fixes mistype in libmisc/env.c |
Description
Fabio Erculiani (RETIRED)
2009-09-05 07:46:15 UTC
Upstream bug: https://alioth.debian.org/tracker/index.php?func=detail&aid=311740&group_id=30580&atid=411480 It was opened for half a year now, so I think Gentoo should patch this issue itself. Patch is provided in the above bug report, but I haven't checked it out, because it seems that registration is needed. Anyway it is a very small fix, and if needed I can make patch myself and upload it here. Please attach the patch here for review. Created attachment 212009 [details, diff]
fixes mistype in libmisc/env.c
I made this patch, but I think it's an exact copy of one in the upstream bug report. I tested it and it works.
After reviewing the upstream source, +1 from me. The code in there is horrible, sanitize_env seems to be O(N^2) when it could be O(N) instead. Thanks everybody involved here, I applied the patch and revision bumped sys-apps/shadow ~arch. I also removed older ~arch versions. +*shadow-4.1.4.2-r1 (04 Dec 2009) + + 04 Dec 2009; Fabio Erculiani <lxnay@gentoo.org> -shadow-4.1.3.1.ebuild, + -shadow-4.1.4.1.ebuild, -shadow-4.1.4.2.ebuild, +shadow-4.1.4.2-r1.ebuild, + +files/shadow-4.1.4.2-env-reset-keep-locale.patch: + Fix invalid environment variables reset, close bug #283725, thanks to + myself for reporting, thanks to parafin for providing a working patch + |