| Summary: | dev-python/Whoosh (New package) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | New packages | Assignee: | Anthony Basile <blueness> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | blueness, proxy-maint, python, sunrise |
| Priority: | High | Keywords: | EBUILD, InOverlay |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://whoosh.ca/ | ||
| Whiteboard: | sunrise-overlay | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 281096 | ||
| Attachments: |
Fresh ebuild
whoosh-2.4.0.ebuild |
||
|
Description
Michał Górny
2009-08-11 12:02:46 UTC
Created attachment 201124 [details]
Fresh ebuild
Example ebuild for current version of Whoosh. Same ebuild works for 0.1.24 (which is required by django-haystack).
Ebuilds are now in Sunrise overlay, you can review them using the following URL: http://overlays.gentoo.org/proj/sunrise/browser/reviewed/dev-python/Whoosh Created attachment 311047 [details]
whoosh-2.4.0.ebuild
Updated ebuild
Lets bring this into the tree. CC:ing blueness since he's interested, python for relevance and proxy if there's anyone interested in co-maintaining this with me \o/ I'll take care of it. Ping in in about 1 week. Exam period = hell! I added Whoosh-2.3.2.ebuild from the sunrise overlay. Hey, thanks for spending time on this! Any specific reason you didn't pick the updated ebuild I attached to this bug? (In reply to comment #7) > Hey, > thanks for spending time on this! > > Any specific reason you didn't pick the updated ebuild I attached to this > bug? No, here's what happened: since the sunrise ebuild was mature, I put it on the tree first. I then went to put the attached one on the tree and noticed you had changed from upper to lower case. I did not continue until I spoke with you first. I've tested both and they're good to go. If we're okay with the upper case name "Whoosh" then I'll make the minor changes the attached ebuild to accomodate that. If not, then we have to migrate. Sorry about the mixup, but I just didn't notice the upper <-> lower switch. Advantages to upper: 1) follows upstream naming scheme. 2) slightly easier to maintain. Disadvantage: 1) most, but not all, packages in the tree use lower case only. Advantages to lower: 1) packages in tree tend to be lower case. Disadvantage: 1) now we have to migrate :( Personal preference: I always try to follow upstream whenever possible to respect their naming convention and there is no breakage with upper <-> lower case, just a convention. However, we can switch if you want.
> However, we can switch if you want.
Actually I spoke with some other devs and their general consensus is "sucks to type" but there's no necessary reason, see dev-perl. So I'll wait for an ack and then make the change.
(In reply to comment #9) > > However, we can switch if you want. > > Actually I spoke with some other devs and their general consensus is "sucks > to type" but there's no necessary reason, see dev-perl. So I'll wait for an > ack and then make the change. I'm fine with whatever, really. My optimal route would be to get an "definitive" answer regarding this - since it feels "wrong" to uppercase, but I can't motivate why (other than something like the reply you got). One argument in this specific case could be that the python modname is actually called "whoosh" (import whoosh). I'm more interested in getting the latest version in tree as well as adding python 3 support (remove restrict). (In reply to comment #10) > (In reply to comment #9) > > > However, we can switch if you want. > > > > Actually I spoke with some other devs and their general consensus is "sucks > > to type" but there's no necessary reason, see dev-perl. So I'll wait for an > > ack and then make the change. > > I'm fine with whatever, really. My optimal route would be to get an > "definitive" answer regarding this - since it feels "wrong" to uppercase, > but I can't motivate why (other than something like the reply you got). One > argument in this specific case could be that the python modname is actually > called "whoosh" (import whoosh). > > I'm more interested in getting the latest version in tree as well as adding > python 3 support (remove restrict). Okay, I think we're good now: 1) dev-python/Whoosh is now renamed to dev-python/whoosh. 2) The ebuild for Whoosh-2.3.2 is gone. I did not move Whoosh-2.3.2.ebuild to whoosh-2.3.2.ebuild 3) whoosh-2.4.0.ebuild is on the tree Take a look Johan, and let me know if this works for you. If we need/want 2.3.2 back, its an easy write, I'll put it back. But it looks like 2.4.0 is better because it is python-3 compat. |