Bug 280539

Summary:	layman should search PATH environment variable for git binary
Product:	Portage Development	Reporter:	Mike Mazur <mmazur>
Component:	Third-Party Tools	Assignee:	Sebastian Pipping <sping>
Status:	RESOLVED FIXED
Severity:	minor	CC:	wolf31o2
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Mike Mazur 2009-08-06 07:15:44 UTC

Currently layman has the path to git hardcoded in layman/overlays/git.py. On systems with the git binary not located at /usr/bin/git (ie: installed in /opt/git from source) layman is unable to process any git-based overlays.

Reproducible: Always

Steps to Reproduce:
1. Move /usr/bin/git to /root/bin/git
2. Add /root/bin to your PATH environment variable
3. Test git works by executing `git --version`
4. Use layman to update or add a git-based overlay


Actual Results:  
layman complains that the git binary is missing and suggests I install git.

Expected Results:  
layman should happily process my request without complaints.

Comment 1 Sebastian Pipping gentoo-dev

2009-12-24 14:56:40 UTC

Out of curiosity: Why do you install Git bypassing Portage? Customizing and ebuild and making Portage eat that is easy. If you're developing Git itself that may be another story, okay.

It seems you're not shy of working with source code.  Do you have time to make us a patch?

Comment 2 Sebastian Pipping gentoo-dev

2009-12-29 14:52:34 UTC

With the current code in Git this is now supported.
You can emerge app-portage/layman-9999 (Layman live ebuild) to check it out.
Add "git_command : git" to /etc/layman/layman.cfg to activate it, default is still /usr/bin/git.

http://layman.git.sourceforge.net/git/gitweb.cgi?p=layman/layman;a=commitdiff;h=1fffa93607c68947ae4eea18bf22f95e0d514a66
http://layman.git.sourceforge.net/git/gitweb.cgi?p=layman/layman;a=commitdiff;h=08c83772f69aaa7edf6c4809365809e8144cce3b