Bug 280293

Summary:	app-emacs/color-theme-6.6.0 breaks several other Emacs apps
Product:	Gentoo Linux	Reporter:	Julian Stecklina <js>
Component:	Current packages	Assignee:	Emacs project <emacs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fix for name clash

Description Julian Stecklina 2009-08-04 11:11:32 UTC

color-theme defines a function 'replace-in-string' that causes name clashes in other Emacs applications, notably Gnus in Emacs 23. A symptom is an error when viewing a signed mail with Gnus. This has already been reported upstream, but the maintainer seems to be AWOL: http://gna.org/bugs/?9494 

Reproducible: Always

Steps to Reproduce:
1. (require 'color-theme)
2. Use Emacs to view signed mails.

Comment 1 Julian Stecklina 2009-08-04 11:14:39 UTC

Created attachment 200137 [details, diff]
Fix for name clash

Comment 2 Julian Stecklina 2009-08-05 10:59:12 UTC

I was wrong about the maintainer. It is fixed in the next release, but it's unclear at the moment when a new release is going to happen. Until then the patch is still needed for 6.6.0

Comment 3 Ulrich Müller gentoo-dev

2009-08-10 00:25:16 UTC

(In reply to comment #1)
> Created an attachment (id=200137) [edit]
> Fix for name clash

Have you actually tested the patch?

This definition shuffles the three arguments around:

-    (defun replace-in-string (target old new)
-      (replace-regexp-in-string old new  target)))

So how can the following work?

-                           (replace-in-string
-                            (replace-in-string 
+                           (replace-regexp-in-string
+                            (replace-regexp-in-string

Comment 4 Ulrich Müller gentoo-dev

2009-08-10 10:07:29 UTC

Fixed in 6.6.0-r1.
Thanks for reporting the issue.