Bug 280112

Summary:	sci-visualization/gnuplot ebuild enhancement
Product:	Gentoo Linux	Reporter:	Jeremy Olexa (darkside) (RETIRED) <darkside>
Component:	New packages	Assignee:	Ulrich Müller <ulm>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	sci
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	gnuplot-4.2.5-r1.ebuild.diff

Description Jeremy Olexa (darkside) (RETIRED) archtester

2009-08-02 22:10:20 UTC

Please consider following the advice of wxwidgets.eclass:

#  Note that with an EAPI 2 ebuild you can just DEPEND on x11-libs/wxGTK:2.8[X]
#  and ignore all this nonsense.

This will avoid a built_with_use check. Since the gnuplot ebuild is already EAPI-2, this should be pretty trivial to implement.

Thanks in advance.

Comment 1 Ryan Hill (RETIRED) gentoo-dev

2009-08-07 21:33:08 UTC

Created attachment 200540 [details, diff]
gnuplot-4.2.5-r1.ebuild.diff

re: irc.  the only time you need to worry about pkg_setup is if you set WX_GTK_VER before inheriting, otherwise the global scope stuff falls through, as does pkg_setup.  since you're using a wxwidgets USE flag here, it's better to do all the wxStuff conditionally (here in src_prepare).  then you can ignore all the hacky crap in the eclass.

Comment 2 Ulrich Müller gentoo-dev

2009-08-07 22:19:31 UTC

(In reply to comment #1)
> Created an attachment (id=200540) [edit]
> gnuplot-4.2.5-r1.ebuild.diff

Applied to 4.2.5-r1 without revbump (moved the code to src_configure instead of src_prepare though).

Thanks Jeremy and Ryan.