| Summary: | tvtime 0.9.9 (version bump) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Henrik Johansson <henjo456> |
| Component: | New packages | Assignee: | Television related Applications in Gentoo's Portage <media-tv> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | billy.biggs, douglas.pollock, gentoovian-bugzilla, iggy, jrmalaq |
| Priority: | High | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
tvtime-0.9.9.ebuild
updated ebuild new ebuild for tvtime-0.9.10 new ebuild for tvtime-0.9.10 new ebuild for tvtime-0.9.10 patch tvtime 0.9.10 ebuild |
||
|
Description
Henrik Johansson
2003-09-05 07:28:58 UTC
Created attachment 17122 [details]
tvtime-0.9.9.ebuild
Some notes about your ebuild: 1. tvtime 0.9.9 no longer has native lirc support, we recommend that users instead use irexec with the 'tvtime-command' application. This should maybe be mentioned in the postinst warning message, and lirc as a dependency should not be listed. I don't know enough about ebuilds though to know if this is done correctly. 2. It should use --sysconfdir=/etc in the configure line, otherwise we won't look there properly. Again I can't tell from your ebuild if this is being done correctly. 3. This ebuild warns about the new XML file format, although there have been no significant changes since the last versions. Isn't it time the postinst message was less threatening? Thanks, -Billy It's not 'my' ebuild really, I've simply renamed tvtime-0.9.8.5.ebuild to tvtime-0.9.9.ebuild :) anyway... 1) I think that ./configure always has checked for lirc so it isn't necessary to use it in the ebuild but it will still show that tvtime can be used with lirc (when running 'emerge tvtime -s') and it will install lirc if one uses that flag. I've added a message about the use of tvtime-command instead of native lirc support in pkg_postinst() 2) I didn't thought of that but it should work since I've just renamed the previous ebuild :) 3) You're probably right, this new XML format was introduced in version 0.9.8 (according to http://tvtime.sourceforge.net/) and the latest version of tvtime in the stable branch is 0.9.8.2 so I removed the warning message Thanks for your comments /Henrik Created attachment 17319 [details]
updated ebuild
I tested the updated ebuild. When it first starts I get the following error... Calculating dependencies ...done! >>> emerge (1 of 1) media-tv/tvtime-0.9.9 to / /usr/sbin/ebuild.sh: line 1: opyright: command not found >>> md5 src_uri ;-) tvtime-0.9.9.tar.gz /usr/sbin/ebuild.sh: line 1: opyright: command not found /usr/sbin/ebuild.sh: line 1: opyright: command not found >>> Unpacking source... >>> Unpacking tvtime-0.9.9.tar.gz to /var/tmp/portage/tvt Then it continues to configure and compile the package, which appears to work without any problems after it is merged. For the benefit of the people following this bug report, Max Kalika and hillster on IRC have both offered to help me out with updating the ebuild, and we have just released tvtime 0.9.10. Hopefully these two guys together can help get the ebuild fixed up and into gentoo. Created attachment 17730 [details]
new ebuild for tvtime-0.9.10
Created attachment 17732 [details]
new ebuild for tvtime-0.9.10
Created attachment 17734 [details]
new ebuild for tvtime-0.9.10
Created attachment 17735 [details, diff]
patch tvtime 0.9.10 ebuild
sorry bout the mess either my browser or bugzilla had a little dummyspit these are the new ebuild and patch to fix a small release bug above for media-tv/tvtime-0.9.10 the 9.10 ebuild is in portage. thanks hillster and vektor. |