Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 279348

Summary: dev-java/freemarker-2.3.19 version bump
Product: Gentoo Linux Reporter: Ben Sagal <bensagal>
Component: Current packagesAssignee: Java team <java>
Status: RESOLVED FIXED    
Severity: normal CC: the.dmol
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://freemarker.org/
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: freemarker-2.3.19.ebuild
files/freemarker-2.3.19-gentoo.patch
freemarker-2.3.19.ebuild
files/freemarker-2.3.19-gentoo.patch

Description Ben Sagal 2009-07-27 17:53:26 UTC
version 2.3.15 of dev-java/freemarker has been out for more than half a year and lasted version in portage is 2.3.13


Reproducible: Always

Steps to Reproduce:
Comment 1 Ben Sagal 2010-11-30 06:08:19 UTC
version 2.3.16 has been available for almost a year
Comment 2 Ivan Baidakou (dmol) 2012-06-12 13:42:36 UTC
Created attachment 315101 [details]
freemarker-2.3.19.ebuild
Comment 3 Ivan Baidakou (dmol) 2012-06-12 13:43:35 UTC
Created attachment 315103 [details, diff]
files/freemarker-2.3.19-gentoo.patch
Comment 4 Ralph Sennhauser (RETIRED) gentoo-dev 2012-09-27 13:18:58 UTC
Some comments to the ebuild:

- don't drop KEYWORDS on version bumps.
- how about using jython:2.5 instead?
- what happened to servlet-api:2.5? why not use the virtual for servlet-api:3.0?
- good you moved javacc to DEPEND, though slot is missing ;)
- multiple ewarn should be replaced by a single einfo or simply a comment in the ebuild, that's far to noisy me thinks.
- you call java-ant_rewrite-bootclasspath twice.
- calling java-pkg_jarfrom in src_compile is better than calling eant in src_prepare. Looking at the build.xml patch you probably can avoid using java-pkg_jarfrom entirely by setting the jar properties.
Comment 5 Ivan Baidakou (dmol) 2012-09-29 19:20:43 UTC
Created attachment 325338 [details]
freemarker-2.3.19.ebuild
Comment 6 Ivan Baidakou (dmol) 2012-09-29 19:21:12 UTC
Created attachment 325342 [details, diff]
files/freemarker-2.3.19-gentoo.patch
Comment 7 Ivan Baidakou (dmol) 2012-09-29 19:29:18 UTC
(In reply to comment #4)

Thank you for your comments. Here's improved ebuild. 

> - don't drop KEYWORDS on version bumps.
OK, but I have dropped ppc as jython:2.5 isn't supported by ppc (repoman complains)

> - how about using jython:2.5 instead?
done

> - what happened to servlet-api:2.5? why not use the virtual for
> servlet-api:3.0?
done

The freemarker uses mixture of jsp-2.0 and jsp-2.1, so, it continue to be dependend on servlet-api-2.4 and servlet-api-3.0

> - good you moved javacc to DEPEND, though slot is missing ;)
it's optional : I've dropped it :)

> - multiple ewarn should be replaced by a single einfo or simply a comment in
> the ebuild, that's far to noisy me thinks.
done

> - you call java-ant_rewrite-bootclasspath twice.
done

> - calling java-pkg_jarfrom in src_compile is better than calling eant in
> src_prepare. Looking at the build.xml patch you probably can avoid using
> java-pkg_jarfrom entirely by setting the jar properties.
I've tried but failed: during compilation phase some targets use jsp-2.0 while others use jsp-2.1. I can't manage that by gentoo.classpath.
Comment 8 James Le Cuirot gentoo-dev 2016-12-22 23:00:44 UTC
Version 2.3.25 is now in the tree.