Summary: | dev-java/freemarker-2.3.19 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ben Sagal <bensagal> |
Component: | Current packages | Assignee: | Java team <java> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | the.dmol |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://freemarker.org/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
freemarker-2.3.19.ebuild
files/freemarker-2.3.19-gentoo.patch freemarker-2.3.19.ebuild files/freemarker-2.3.19-gentoo.patch |
Description
Ben Sagal
2009-07-27 17:53:26 UTC
version 2.3.16 has been available for almost a year Created attachment 315101 [details]
freemarker-2.3.19.ebuild
Created attachment 315103 [details, diff]
files/freemarker-2.3.19-gentoo.patch
Some comments to the ebuild: - don't drop KEYWORDS on version bumps. - how about using jython:2.5 instead? - what happened to servlet-api:2.5? why not use the virtual for servlet-api:3.0? - good you moved javacc to DEPEND, though slot is missing ;) - multiple ewarn should be replaced by a single einfo or simply a comment in the ebuild, that's far to noisy me thinks. - you call java-ant_rewrite-bootclasspath twice. - calling java-pkg_jarfrom in src_compile is better than calling eant in src_prepare. Looking at the build.xml patch you probably can avoid using java-pkg_jarfrom entirely by setting the jar properties. Created attachment 325338 [details]
freemarker-2.3.19.ebuild
Created attachment 325342 [details, diff]
files/freemarker-2.3.19-gentoo.patch
(In reply to comment #4) Thank you for your comments. Here's improved ebuild. > - don't drop KEYWORDS on version bumps. OK, but I have dropped ppc as jython:2.5 isn't supported by ppc (repoman complains) > - how about using jython:2.5 instead? done > - what happened to servlet-api:2.5? why not use the virtual for > servlet-api:3.0? done The freemarker uses mixture of jsp-2.0 and jsp-2.1, so, it continue to be dependend on servlet-api-2.4 and servlet-api-3.0 > - good you moved javacc to DEPEND, though slot is missing ;) it's optional : I've dropped it :) > - multiple ewarn should be replaced by a single einfo or simply a comment in > the ebuild, that's far to noisy me thinks. done > - you call java-ant_rewrite-bootclasspath twice. done > - calling java-pkg_jarfrom in src_compile is better than calling eant in > src_prepare. Looking at the build.xml patch you probably can avoid using > java-pkg_jarfrom entirely by setting the jar properties. I've tried but failed: during compilation phase some targets use jsp-2.0 while others use jsp-2.1. I can't manage that by gentoo.classpath. Version 2.3.25 is now in the tree. |