Bug 279245

Summary:	mplayer should not set +X or +xscreensaver in IUSE
Product:	Gentoo Linux	Reporter:	Daniel Robbins <drobbins>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Daniel Robbins 2009-07-27 01:07:30 UTC

mplayer can be used by non-desktop media servers for media encoding, so +X and +xscreensaver should not be set in IUSE. Instead, 'X xscreensaver' should be used so the profile can have control over whether  or not to build GUI components, by enabling them in desktop configurations. Affects:

mplayer-9999.ebuild
mplayer-1.0_rc2_p28450.ebuild

Reproducible: Always

Steps to Reproduce:
on server:
emerge mplayer or emerge mediatomb
X gets pulled in



Expected Results:  
on server:
emerge mplayer or emerge mediatomb
X is not pulled in.

Comment 1 Steve Dibb (RETIRED) gentoo-dev

2009-08-03 20:33:54 UTC

Sorry, Daniel, gonna close this one as WONTFIX.  MPlayer is a special case where enabling "too many" use flags causes far less issues than users complaining that their playback is slow / crappy / missing codecs / etc.

Besides that, X isn't the only thing pulling in X11 libraries.   xv, for instance, does, which is also enabled by default.

Comment 2 Daniel Robbins 2009-08-05 17:35:12 UTC

With Gentoo's modular profile system, there's no reason (that I know of) why you can't accommodate both groups.

What would be a much better solution is to enable these X-specific options in the desktop profile, in make.defaults (if you want to enable them globally) or package.use (if you want them specific to mplayer) - and leave them disabled by default in the ebuild. Then you manage the gui options there.

This way, desktop users use the desktop profile and all the gui options get auto-enabled in all packages all at once.

And more importantly, server-based media server users aren't placed in the tricky position of figuring out what of the zillion USE vars is pulling in X.

Please reconsider. It would save me a bit of upstream merging work but generally I think it's the right way to go.

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2009-08-05 17:43:35 UTC

drobbins, if fact, this is very much same issue as in bug 222627 which was already reopened...

please follow up there.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2009-08-05 17:43:46 UTC


*** This bug has been marked as a duplicate of bug 222627 ***