Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 278695

Summary: dev-db/ctdb-1.0.86: Version bump
Product: Gentoo Linux Reporter: John Simmonds (overfuse) <john2.simmonds>
Component: New packagesAssignee: Gentoo's SAMBA Team <samba>
Status: RESOLVED FIXED    
Severity: enhancement CC: john2.simmonds
Priority: High Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 278141    
Attachments: ctdb-1.0.86.ebuild (New Ebuild)
Required patch used by ebuild ctdb-1.0.86.ebuild
Corrected Header ctdb-1.0.86.ebuild (New Ebuild)
Init Script for CTDB
ctdb-1.0.86.ebuild (New Ebuild)
Required Init SysV script used by ebuild ctdb-1.0.86.ebuild
ctdb-1.0.86.ebuild (New Ebuild)
ctdb-1.0.86.ebuild (New Ebuild)
Required patch used by ebuild ctdb-1.0.86.ebuild (50.samba)
Required patch used by ebuild ctdb-1.0.86.ebuild (41.httpd)
Required Init SysV script used by ebuild ctdb-1.0.86.ebuild
Required patch used by ebuild ctdb-1.0.86.ebuild (functions)

Description John Simmonds (overfuse) 2009-07-22 15:29:05 UTC
I have created a new ebuild for ctdb. Its based on ctdb-1.0.73.ebuild.

Changes from previous ebuild ctdb-1.0.73:

A) Changes 'src_prepare' to 'src_unpack' for quality reasons. 

B) Includes a new patch I have created called ctdb-functions.patch. This patch is also compatible with previous versions so I will be back-porting it for the older version, ctdb-1.0.73, and raising a separate bug for that.

Reproducible: Always
Comment 1 John Simmonds (overfuse) 2009-07-22 15:29:37 UTC
Created attachment 198796 [details]
ctdb-1.0.86.ebuild (New Ebuild)
Comment 2 John Simmonds (overfuse) 2009-07-22 15:30:15 UTC
Created attachment 198797 [details, diff]
Required patch used by ebuild ctdb-1.0.86.ebuild
Comment 3 John Simmonds (overfuse) 2009-07-22 15:33:24 UTC
Created attachment 198798 [details]
Corrected Header ctdb-1.0.86.ebuild (New Ebuild)

Opps, my mistake. I made a common new ebuild error of forgetting to put in the vaild header rather then use the old ebuild's header that it was based on.
Comment 4 John Simmonds (overfuse) 2009-07-22 15:34:18 UTC
Comment on attachment 198797 [details, diff]
Required patch used by ebuild ctdb-1.0.86.ebuild

Place in the 'files' folder for this ebuild to use.
Comment 5 John Simmonds (overfuse) 2009-07-22 15:47:44 UTC
Created attachment 198801 [details]
Init Script for CTDB

I am attaching a Init script for use with CTDB. Put this file in /etc/init.d and use it to start and stop ctdb.

I hope very soon to change the ebuild to do this automatically for you.
Comment 6 John Simmonds (overfuse) 2009-07-22 16:03:00 UTC
Created attachment 198803 [details]
ctdb-1.0.86.ebuild (New Ebuild)

Added installing of Init script and the template for /etc/conf.d/ctdb
Comment 7 John Simmonds (overfuse) 2009-07-22 16:06:13 UTC
Created attachment 198804 [details]
Required Init SysV script used by ebuild ctdb-1.0.86.ebuild
Comment 8 John Simmonds (overfuse) 2009-07-22 16:07:13 UTC
Comment on attachment 198804 [details]
Required Init SysV script used by ebuild ctdb-1.0.86.ebuild 

Place in the 'files' folder for this ebuild to use.
Comment 9 John Simmonds (overfuse) 2009-07-22 16:11:59 UTC
I have sent this patch and Init script upstream to Samba as well, see:
https://bugzilla.samba.org/show_bug.cgi?id=6571
Comment 10 John Simmonds (overfuse) 2009-07-22 16:29:38 UTC
The only things left to do is to make some changes to the scripts in events.d/ that come with CTDB.

I hope to do that early next week and upload the patches. Then modify the ebuild again to automatically patch. Then it should be pretty much done.

Either way its better than the ctdb currently in the portage tree. If anyone wants to take a look at patching some of the events.d scripts please do!
Comment 11 Tiziano Müller (RETIRED) gentoo-dev 2009-07-22 17:17:44 UTC
(In reply to comment #7)
> Created an attachment (id=198804) [edit]
> Required Init SysV script used by ebuild ctdb-1.0.86.ebuild 
> 

Looks good, but is there a specific reason why those options can't be given in conf.d/ctdb with one single variable?
The restart function can be removed btw.
Comment 12 Tiziano Müller (RETIRED) gentoo-dev 2009-07-22 17:18:50 UTC
(In reply to comment #6)
> Created an attachment (id=198803) [edit]
> ctdb-1.0.86.ebuild (New Ebuild)
> 
> Added installing of Init script and the template for /etc/conf.d/ctdb
> 

src_prepare as in the ebuild in the tree is fine. You don't need src_unpack and then manually call unpack, etc.
Comment 13 John Simmonds (overfuse) 2009-07-27 13:00:01 UTC
Created attachment 199332 [details]
ctdb-1.0.86.ebuild (New Ebuild)


Updated ebuild to reflect what Tiziano Müller said, see:

(In reply to comment #12)
> 
> src_prepare as in the ebuild in the tree is fine. You don't need src_unpack and
> then manually call unpack, etc.
>
Comment 14 John Simmonds (overfuse) 2009-07-28 17:58:10 UTC
Created attachment 199458 [details]
ctdb-1.0.86.ebuild (New Ebuild)

Added two additional patches for events.d script's 50.samba and 41.httpd. I think that's all the events.d scripts that need patching for Gentoo.
Comment 15 John Simmonds (overfuse) 2009-07-28 17:58:51 UTC
Created attachment 199460 [details, diff]
Required patch used by ebuild ctdb-1.0.86.ebuild (50.samba)
Comment 16 John Simmonds (overfuse) 2009-07-28 17:59:58 UTC
Created attachment 199461 [details, diff]
Required patch used by ebuild ctdb-1.0.86.ebuild (41.httpd)
Comment 17 John Simmonds (overfuse) 2009-07-28 18:02:46 UTC
Created attachment 199463 [details, diff]
Required Init SysV script used by ebuild ctdb-1.0.86.ebuild

Removed unneeded restart function
Comment 18 John Simmonds (overfuse) 2009-07-29 18:47:11 UTC
Created attachment 199581 [details, diff]
Required patch used by ebuild ctdb-1.0.86.ebuild (functions)

Created an attachment (id=4480) [details]
Patch file to ./config/functions (/etc/ctdb/functions)

Found a bug in original "198797: Required patch used by ebuild ctdb-1.0.86.ebuild".

This fixes it.
Comment 19 Patrick Lauer gentoo-dev 2009-10-09 22:49:17 UTC
+  09 Oct 2009; Patrick Lauer <patrick@gentoo.org> +ctdb-1.0.88.ebuild,
+  +files/ctdb-41.httpd_gentoo.patch, +files/ctdb-50.samba_gentoo.patch,
+  +files/ctdb.initd, +files/ctdb-functions.patch:
+  Bump to 1.0.88, thanks to John Simmonds for the patches and modified
+  ebuild. Closes #278695


Haven't tested init script, but it looks sane enough :)
Also saw no reason to drop keywords, so restored them as in the "old" ebuild