| Summary: | kernel-2.eclass: default unipatch directory | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Eclasses | Assignee: | Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel> |
| Status: | CONFIRMED --- | ||
| Severity: | enhancement | CC: | gef.kornflakes, pacho |
| Priority: | High | Keywords: | NeedPatch |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Michał Górny
2009-07-20 00:32:02 UTC
Interesting, though this may be problematic: 1. How would we deal with patches that break? (For example, the UAPI header move) Or maybe the question is rather to avoid them breaking. I'm mainly thinking about the order in which patches run here, when would we apply these patches? One could argue to put them at the start so they cleanly apply against the kernel, but then the genpatches would have to work against undefined changes. We can't know which patches could possibly be in /etc/portage/unipatch, it would be exhaustive to make sure that patch sets like genpatches would work about any possible patches that could be put there. So, I think we need to apply the patches from /etc/portage/unipatch after any other patchsets. Though then patches from /etc/portage/unipatch would need to be adapted to apply after the patchsets. I feel that if we do it this way it would be reasonable, since the chance they collide with the limited patches is small; it starts to come problematic with heavier patch sets that are used a lot like hardened or the out-of-tree geek-sources. Tricky business... 2. How do we deal with multiple kernel versions? Creating a folder for each branch likely doesn't work, because a patch may break between two versions in a branch; we also can't make a folder for each version either. Some kind of more advanced logic would be necessary here. We'll need to put some more thought into this before we can implement this. |