Bug 277450

Summary:	=dev-util/monotone-0.44 has unnecessary strip-flags and tests FEATURES
Product:	Gentoo Linux	Reporter:	Jack Lloyd <lloyd>
Component:	New packages	Assignee:	Daniel Black (RETIRED) <dragonheart>
Status:	RESOLVED FIXED
Severity:	QA	CC:	johnny, qa
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---

Description Jack Lloyd 2009-07-11 18:20:39 UTC

The current monotone-0.44 ebuild has the following in src_compile():

# more aggressive optimizations cause trouble with the crypto library
strip-flags
append-flags $(test-flags -fno-stack-protector-all -fno-stack-protector)
append-flags -fno-strict-aliasing -fno-omit-frame-pointer

None of these should be necessary; for one because the crypto library that was having problems with these flags was Crypto++, which monotone stopped using in version 0.22 (almost 4 years ago) and additionally since version 0.43 monotone does not even include the source of the crypto library anymore but requires it already be installed.

Reproducible: Always

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2009-07-12 17:25:55 UTC

In addition to this, the ebuild is doing:

if ! has userpriv ${FEATURES} && has test ${FEATURES}; then
ewarn "No test will be performed due to lack of FEATURES=userpriv"
fi

Which is wrong since FEATURES shouldn't be tested from inside ebuild. Instead of this it should be doing something like:

if [ $UID == 0 ]; then
..
fi

or

if [ $UID != 0 ]; then
..
fi

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2009-07-16 09:44:19 UTC

+  16 Jul 2009; Samuli Suominen <ssuominen@gentoo.org> monotone-0.44.ebuild:
+  Remove obsolete strip-flags and replace FEATURES testing by UID testing
+  wrt #277450, thanks to Jack Lloyd for reporting.