Bug 277420

Summary:	sci-calculators/grpn: fails tests with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	QA
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log patch for ebuild to respect LDFLAGS and add RESTRICT=test

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-07-11 11:57:28 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-07-11 11:57:52 UTC

Created attachment 197524 [details]
Build log

Comment 2 Thomas Beierlein gentoo-dev

2009-09-15 18:24:07 UTC

Looking into the package there seems not to be a serious test suite but only one file test.c which seems to be a relict of some testing experiments.

I would recommend adding 'RESTRICT="test"' to the ebuild.

The package does also not respect LDFLAGS. That must still be fixed.

Comment 3 Thomas Beierlein gentoo-dev

2009-09-15 19:01:09 UTC

Created attachment 204236 [details, diff]
patch for ebuild to respect LDFLAGS and add RESTRICT=test

Attached patch fixes the LDFLAGS problem.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2009-12-19 19:38:46 UTC

+  19 Dec 2009; Samuli Suominen <ssuominen@gentoo.org> grpn-1.1.2-r1.ebuild:
+  RESTRICT="test" and respect LDFLAGS wrt #277420, thanks to Diego E.
+  'Flameeyes' Pettenò and Thomas Beierlein.