Bug 276506

Summary:	app-admin/lsyncd: fails with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Ioannis Aslanidis (RETIRED) <deathwing00>
Status:	RESOLVED FIXED
Severity:	QA	CC:	esigra, xarthisius
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log adding patch to ebuild, running autotools, adding IUSE, adding optional depends fixing as-needed issues

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-07-04 21:36:47 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-07-04 21:37:40 UTC

Created attachment 196685 [details]
Build log

Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-01-09 19:46:30 UTC

Created attachment 215856 [details, diff]
adding patch to ebuild, running autotools, adding IUSE, adding optional depends

1. lsyncd can be build without libxml2 -> adding IUSE=xml
2. it's missing depend when build with xml support (it was default)

Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-01-09 19:47:30 UTC

Created attachment 215857 [details, diff]
fixing as-needed issues

also slightly rebuilding configure.in to make it simpler and respect USE flags

Comment 4 Kevin Pyle 2010-01-09 21:49:04 UTC

(In reply to comment #2)
> Created an attachment (id=215856) [details]
> adding patch to ebuild, running autotools, adding IUSE, adding optional depends

If you bump the ebuild to EAPI=2, you can move the epatch+eautoreconf to src_prepare, move the econf to src_configure, and use the default implementations of src_unpack and src_compile.

Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-01-10 10:40:59 UTC

(In reply to comment #4)
 
> If you bump the ebuild to EAPI=2, you can move the epatch+eautoreconf to
> src_prepare, move the econf to src_configure, and use the default
> implementations of src_unpack and src_compile.

True, but it's not my package. Things like EAPI change are maintainer's privilege. I've only added things necessary for package to work properly.

Comment 6 Samuli Suominen (RETIRED) gentoo-dev

2010-06-29 15:49:07 UTC

+  29 Jun 2010; Samuli Suominen <ssuominen@gentoo.org> lsyncd-1.33.ebuild,
+  +files/lsyncd-1.33-libxml2.patch:
+  Fix building with -Wl,--as-needed wrt #276506 by Kacper Kowalik.