| Summary: | [PATCH] mod-ruby-1.1.1-r2.ebuild mod_ruby for apache 1.3.x | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jeff Mitchell <quixoticsycophant> |
| Component: | New packages | Assignee: | Gentoo Ruby Team <ruby> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | somekool |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | mod_ruby ebuild patch for apache-1.3.28 | ||
oops forgot ${ROOT}. use this:
diff -ur /usr/portage/dev-ruby/mod-ruby/files/mod_ruby.conf ./files/mod_ruby.conf
--- /usr/portage/dev-ruby/mod-ruby/files/mod_ruby.conf 2003-05-10 09:17:52.000000000 -0400
+++ ./files/mod_ruby.conf 2003-08-31 10:42:22.000000000 -0400
@@ -1,5 +1,5 @@
# REQUIRED
-LoadModule ruby_module /usr/local/apache/libexec/mod_ruby.so
+LoadModule ruby_module extramodules/mod_ruby.so
<IfModule mod_ruby.c>
# for Apache::RubyRun
diff -ur /usr/portage/dev-ruby/mod-ruby/mod-ruby-1.1.1-r2.ebuild ./mod-ruby-1.1.1-r2.ebuild
--- /usr/portage/dev-ruby/mod-ruby/mod-ruby-1.1.1-r2.ebuild 2003-06-10 20:15:17.000000000 -0400
+++ ./mod-ruby-1.1.1-r2.ebuild 2003-08-31 10:42:08.000000000 -0400
@@ -76,9 +76,7 @@
if [ "`use apache2`" ]; then
:
else
- ${ROOT}/usr/sbin/apacheaddmod \
- ${ROOT}/etc/apacheconf/conf/apache.conf \
- extramodules/mod_ruby.so mod_ruby.c ruby_module \
- before=perl define=RUBY addconf=conf/addon-modules/mod_ruby.conf
+ echo -e "<IfDefine RUBY>\n Include conf/addon-modules/mod_ruby.conf\n</IfDefine>" >> \
+ ${ROOT}/etc/apache/conf/apache.conf
fi
}
Created attachment 16922 [details, diff]
mod_ruby ebuild patch for apache-1.3.28
silly me, I didn't know about patch attachments. sorry bout that.
(use the attachment and ignore all these other comments) Also, this is a typo: einfo "You may also wish to edit /etc/conf.d/apache2/modules.d/20_mod_ruby.conf" it should be /etc/apache2/conf/modules.d/20_mod_ruby.conf The patch, as supplied, will add <IfDefine Ruby>... etc. every time mod_ruby is emerged. i.e. after a couple of upgrades there will be multiple copies in the .conf. This isn't good. The behavior is the same as it was. The <IfDefine> is not automatically added. It is in pkg_config(). After emerging, the user sees * To enable mod_ruby: * 1. Run "ebuild /var/db/pkg/dev-ruby/mod-ruby-1.1.1-r2/mod-ruby-1.1.1-r2.ebuild config" * 2. Edit /etc/conf.d/apache and add "-D RUBY" If it's already in apache.conf, the user will not (should not) run the config. Given your reasoning, are you also concerned about the user adding another "-D RUBY" to his conf.d file every time? There's a new version of mod_ruby out... Sorry for the delay. I've just applied the patch. Thanks for the contribution. so how come this bug is fix and I can't install mod_ruby without download an extra ebuild file ?? you named it, mod-ruby but mod_php is named mod_php would you please use consistent naming ? All right, I moved it to dev-ruby/mod_ruby. |
config had a bad filename, and apacheaddmod seems incompatible and/or unnecessary with the new-style addon-modules/ directory. diff -ur /usr/portage/dev-ruby/mod-ruby/files/mod_ruby.conf ./files/mod_ruby.conf --- /usr/portage/dev-ruby/mod-ruby/files/mod_ruby.conf 2003-05-10 09:17:52.000000000 -0400 +++ ./files/mod_ruby.conf 2003-08-31 10:42:22.000000000 -0400 @@ -1,5 +1,5 @@ # REQUIRED -LoadModule ruby_module /usr/local/apache/libexec/mod_ruby.so +LoadModule ruby_module extramodules/mod_ruby.so <IfModule mod_ruby.c> # for Apache::RubyRun diff -ur /usr/portage/dev-ruby/mod-ruby/mod-ruby-1.1.1-r2.ebuild ./mod-ruby-1.1.1-r2.ebuild --- /usr/portage/dev-ruby/mod-ruby/mod-ruby-1.1.1-r2.ebuild 2003-06-10 20:15:17.000000000 -0400 +++ ./mod-ruby-1.1.1-r2.ebuild 2003-08-31 10:42:08.000000000 -0400 @@ -76,9 +76,7 @@ if [ "`use apache2`" ]; then : else - ${ROOT}/usr/sbin/apacheaddmod \ - ${ROOT}/etc/apacheconf/conf/apache.conf \ - extramodules/mod_ruby.so mod_ruby.c ruby_module \ - before=perl define=RUBY addconf=conf/addon-modules/mod_ruby.conf + echo -e "<IfDefine RUBY>\n Include conf/addon-modules/mod_ruby.conf\n</IfDefine>" >> \ + /etc/apache/conf/apache.conf fi }