Bug 276401

Summary:	net-mail/uw-mailutils should honor pam and ssl USE flags
Product:	Gentoo Linux	Reporter:	DC <gtbgs>
Component:	New packages	Assignee:	Net-Mail Packages <net-mail+disabled>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch against uw-mailutils-2007e.ebuild Updated patch to make $sslflags local patch to uw-mailutils-2007e adding pam and ssl USE flags revize ssl dirs

Description DC 2009-07-03 21:34:43 UTC

net-mail/uw-mailutils-2007e currently builds with SSL and PAM disabled, regardless of whether they were requested by the USE flags. This patch enables SSL and PAM if the USE flags requested them.

Reproducible: Always

Steps to Reproduce:

Comment 1 DC 2009-07-03 21:36:54 UTC

Created attachment 196544 [details, diff]
Patch against uw-mailutils-2007e.ebuild

Comment 2 Eray Aslan gentoo-dev

2009-07-04 07:28:15 UTC

Perhaps it would be better if you

* declared sslflags as local
* quoted sslflags in the make statement.

Thanks for the patch.

Comment 3 DC 2009-07-04 22:31:19 UTC

Making sslflags local is a good idea -- thanks for the suggestion.

I don't want to quote sslflags though, because it's a string that can contain more than one make setting, and I want make to see them as separate args.

Comment 4 DC 2009-07-04 22:36:24 UTC

Created attachment 196690 [details, diff]
Updated patch to make $sslflags local

Comment 5 Eray Aslan gentoo-dev

2009-07-05 08:03:45 UTC

(In reply to comment #3)
> I don't want to quote sslflags though, because it's a string that can contain
> more than one make setting, and I want make to see them as separate args.

Two points:
* passing unquoted areguments is not safe enough
* SSLINCLUDE and SSLIB directives errors out when compiling mtest.c further down the emerge.

Please check the attachment for an alternative.

Comment 6 Eray Aslan gentoo-dev

2009-07-05 08:06:07 UTC

Created attachment 196719 [details, diff]
patch to uw-mailutils-2007e adding pam and ssl USE flags

Comment 7 Eray Aslan gentoo-dev

2009-07-05 08:07:43 UTC

Created attachment 196720 [details, diff]
revize ssl dirs

Comment 8 DC 2009-07-05 21:20:06 UTC

I tested your new patches, and they work for me. Thanks!

Comment 9 Eray Aslan gentoo-dev

2011-05-06 21:00:49 UTC

+*uw-mailutils-2007e-r1 (06 May 2011)
+
+  06 May 2011; Eray Aslan <eras@gentoo.org> +uw-mailutils-2007e-r1.ebuild,
+  +files/uw-mailutils-ssl.patch:
+  add pam and ssl USE flags - bugs 129729 276401
+