| Summary: | www-client/mozilla-firefox-3.5-r2: fix iceweasel branding | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Fiona Klute <fiona.klute> |
| Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | minor | CC: | bugs_gentoo_org.Tim_OKelly, rdwald |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
patch for www-client/mozilla-firefox-3.5-r2 ebuild to fix iceweasel icons
Patch for correct iceweasel icons/text in mozilla-firefox-3.5.3 |
||
|
Description
Fiona Klute
2009-07-03 18:48:46 UTC
Created attachment 196529 [details, diff]
patch for www-client/mozilla-firefox-3.5-r2 ebuild to fix iceweasel icons
This patch fixes the bug for me. It might be better to update the iceweasel-icons tarball, though.
We need a fresh upstream iceweasel release before this can be fixed cleanly... (In reply to comment #2) > We need a fresh upstream iceweasel release before this can be fixed cleanly... > iceweasel is nothing more then debian patched firefox. Iceweasel should be drop'd from the ebuild, all it provides is icons that the user can change locally. If user does not wish to enable official branding they should stick with the normal naming as mozilla has laid out, any bug reports that go upstream with any mention of iceweasel are rejected and closed invalid. (In reply to comment #3) > (In reply to comment #2) > > We need a fresh upstream iceweasel release before this can be fixed cleanly... > > > > iceweasel is nothing more then debian patched firefox. Iceweasel should be > drop'd from the ebuild, all it provides is icons that the user can change > locally. Yes, we all know that, and by "upstream iceweasel release" I meant debian folks release a source deb so we can get the newer iceweasel icons. Debian now has Iceweasel 3.5 in "experimental": http://packages.debian.org/source/experimental/iceweasel They build the PNG and XPM icons from SVG source files, though. Should Gentoo do the same, or should we rather copy the icons from Debian's binary package (which seems to be the current behavior)? Unless we're copying Iceweasel's patches to upstream Firefox as well as their branding, it seems disingenuous to call our version Iceweasel. I guess it would be possible to keep a copy of all the Debian patches and apply them instead of the Gentoo ones when the iceweasel USE flag is applied, but that doesn't seem to be what is happening. I mean, I'm sure that the Debian folks put the name and logos under a license which lets Gentoo do this, it just seems silly to build a different version of the browser than the "official" Iceweasel and still call it Iceweasel. What if someone redistributes your Gentoo Iceweasel and the bugs get reported back to Debian? </sarcasm> I still say we need to drop the iceweasel useflag and icons. We have enough work to support firefox alone let alone worry about debian patches and icons. Created attachment 205016 [details, diff]
Patch for correct iceweasel icons/text in mozilla-firefox-3.5.3
Updated version for mozilla-firefox-3.5.3
I find it interesting that a certain ebuild line was changed to in 3.5.3: "- sed -i -e "s:Minefield:Iceweasel:" browser/locales/en-US/chrome/branding/brand.* \ - browser/branding/nightly/configure.sh || die "iceweasel sed failed!"" I see no reason for the need to change the pipes to colons, and especially find it interesting that someone went through the effort of adding a nice die option in the case of this failing, but did not address the issue that the unbranded version of firefox has been referring to itself as "Shiretoko", not, "Minefield", for the past few versions. Anyway, my patch reverts these trivial (as far as I can tell) changes to their 3.5-r2 versions, for what it's worth. If anyone from mozilla herd can give me just cause why we should keep this ridiculous useflag namechange for nothing more then an icon change please speak now, if noone has any objections in next 7 days I will remove the iceweasel useflag and support. I would rather put IceCat in the tree which is designed to handle the icon issues. I agree having a USE flag to "de-brand" mozilla-firefox is a bit weird. Better to have a dedicated package and GNU IceCat is probably a better choice than IceWeasel in these conditions. I have added icecat to mozilla overlay and would like those who so wish for iceweasel to test and use it as the alternative to renaming the package installed for just icon changes. Just installed IceCat. Works pretty well, but the "About" window is broken for non-English locales. I installed support for German, Japanese and English and tested with de_DE.UTF-8, ja_JP.UTF-8, en_US.UTF-8 and C locale settings. The de_DE.UTF-8 and ja_JP.UTF-8 locales show the same behavior: When clicking the "About" entry in the "Help" menu, the appearing window contains an error message from the XML-parser. The German one looks like this:
XML-Verarbeitungsfehler: Nicht definierte Entität
Adresse: chrome://browser/content/aboutDialog.xul
Zeile Nr. 40, Spalte 9: &logoCopyright;
--------^
As I can't to reproduce the error with English locale settings, I'm unable to provide an English error message. However, "Nicht definierte Entität" translates to "Undefined Entity".
(In reply to comment #13) > Just installed IceCat. Works pretty well, but the "About" window is broken for > non-English locales. I installed support for German, Japanese and English and > tested with de_DE.UTF-8, ja_JP.UTF-8, en_US.UTF-8 and C locale settings. The > de_DE.UTF-8 and ja_JP.UTF-8 locales show the same behavior: When clicking the > "About" entry in the "Help" menu, the appearing window contains an error > message from the XML-parser. The German one looks like this: > > XML-Verarbeitungsfehler: Nicht definierte Entität > Adresse: chrome://browser/content/aboutDialog.xul > Zeile Nr. 40, Spalte 9: &logoCopyright; > --------^ > As I can't to reproduce the error with English locale settings, I'm unable to > provide an English error message. However, "Nicht definierte Entität" > translates to "Undefined Entity". > Please, open a new bug for this issue. iceweasel is being drop'd, icecat was added to the tree and will be on mirrors soon. |
