Summary: | media-libs/imlib2 fails with forced --as-needed and --no-undefined | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christian Ruppert (idl0r) <idl0r> |
Component: | Current packages | Assignee: | SpanKY <vapier> |
Status: | RESOLVED FIXED | ||
Severity: | minor | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 129413 | ||
Attachments: |
as-needed.patch
imlib2-1.4.2-r1.ebuild.diff |
Description
Christian Ruppert (idl0r)
2009-07-02 20:00:15 UTC
Created attachment 196425 [details, diff]
as-needed.patch
Created attachment 196427 [details, diff]
imlib2-1.4.2-r1.ebuild.diff
as a dev, you really should be aware of proper patch management. that means creating a patch named "as-needed.patch" is certainly not acceptable. going beyond that, you should review this document: http://dev.gentoo.org/~vapier/clean-patches and to address the original issue, such a trivial change really shouldnt be done to the autotool source files, especially considering it alone needs to run a full autoreconf. a simple sed can accomplish the same exact thing without forcing significantly more build time overhead. http://sources.gentoo.org/media-libs/imlib2/imlib2-1.4.2-r1.ebuild?r1=1.6&r2=1.7 |