Bug 27541 – USE="-nls" should be handled in econf()

• Product: Portage Development
• Status: RESOLVED WONTFIX

[Description Markus Nigbur (RETIRED) 2003-08-29 08:15:30 UTC]

At the current state, all ebuilds of packages that have nls support need to
handle it theirself.
Unfortunately some don't.

Anyway, it would be much easier to check for the presence of -nls in the
useflags in the econf() function of ebuild.sh and disable nls directly.

[Comment 1 Markus Nigbur (RETIRED) 2003-08-29 08:16:49 UTC]

Created attachment 16762 [details, diff]
Proposed patch

[Comment 2 SpanKY 2003-08-29 08:24:46 UTC]

some older configure scripts dont like it when you pass options it doesnt support 
... thus if you go passing --enable-nls or --disable-nls to a script that doesnt have 
nls comments it'll die 

[Comment 3 SpanKY 2003-08-29 08:58:16 UTC]

lemme double check on this ... and leave it open in case i'm wrong ... 

[Comment 4 Mr. Bones. (RETIRED) 2003-08-29 10:10:10 UTC]

Even if you're right Spanky, I think it'd be better to fix the older ebuilds
to handle -nls themselves so that newer ones didn't have to.

[Comment 5 Markus Nigbur (RETIRED) 2003-08-29 20:43:57 UTC]

i know of people who manually added --disable-nls to ebuild.sh since month, they didn't run into problems with any ebuild.

i must admit, there _might_ be some packages where your statement is true, if so, please let me know of those. i'm pretty sure i'm able to add a workaround for configure scripts that fail when passing invalid options to it.

all i have seen so far check if specific options are passed to them, 'invalid' options will just be ignored.

[Comment 6 Nicholas Jones (RETIRED) 2003-12-24 18:23:07 UTC]

Seemant: Your opinion?

[Comment 7 Seemant Kulleen (RETIRED) 2003-12-25 13:10:10 UTC]

RE: what Spanky said in his first comment -- I know of one (there may be more) that is very choosy about wrong options sent to configure.  I don't recall which one it is, exactly, but it's somewhere in sys- (I wanna say sys-apps, but I dunno for sure).  Now, I do think that nls is an often enough occurrence that it would take a big headache.  One way that this might be done gracefully, is just check if the IUSE has "nls" in it?

Not sure on that though.  I do, however, like the idea of auto-disabling-nls

[Comment 8 Nicholas Jones (RETIRED) 2004-01-21 21:39:04 UTC]

If someone can come up with a difinitive solution to this or wants
to take it for exploration, feel free to reopen it.

I don't see it as feasable unless someone wants to find and fix all
the general/stage1-3+kde/gnome packages in a complete system that
break. Can't just deploy this change.

[Comment 9 Marius Mauch (RETIRED) 2007-01-11 12:20:05 UTC]

Reopening for consideration.

[Comment 10 Marius Mauch (RETIRED) 2007-06-05 18:27:33 UTC]

Looks like we survived without this for the last three years, and I'm not in favor of adding support for specific USE flags into portage unless absolutely necessary.