Bug 27493 – it would be nice if the hydrogen ebuild also fetched the drumkits

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Kasper Souren 2003-08-28 12:34:15 UTC]

It would be nice if the hydrogen ebuild also fetched the available drumkits. 
(http://hydrogen.sourceforge.net/site.php?page=drumkits) 
A flag could be USEful here.

[Comment 1 Mr. Bones. (RETIRED) 2003-08-28 12:39:12 UTC]

*** Bug 27494 has been marked as a duplicate of this bug. ***

[Comment 2 CJ Kucera 2003-09-02 20:33:51 UTC]

I think this would be nice too.  I'm investigating what it would take.  The default drumkit, GMkit, is actually a part of libhydrogen, not the actual hydrogen package, so it would probably have to go there.  As it turns out, simply dumping the drumkit directories in /usr/share/hydrogen/data/drumkits isn't quite enough.  I'll post an ebuild once I've got it working though.

[Comment 3 CJ Kucera 2003-09-05 22:13:20 UTC]

Created attachment 17142 [details]
libhydrogen-0.8.0-r1.ebuild

*whew* - Now *there* is a beast.

Yes, shoehorning in the drumkits into the libhydrogen ebuild isn't exactly
pretty.  I'm attaching a version of it that *does,* in fact, load all the
drumkits in properly.  The actual code in here is pretty hideous; I wouldn't
recommend actually committing it without serious improvement (which I'd be
happy to do if the Powers That Be deem this enhancement worthy enough to
include in Portage), but it does work.

Essentially, you have to fetch the drumkit tarballs from the sf.net site (so
we're not eating up mirror space by doing this), unpack those, and then unpack
some of the files in THERE (named .h2drumkit, but they're really just tgz
files) into libhydrogen's data/drumkits directory.

From there, you've got to copy the default drumkit's (GMkit) Makefiles into all
of the new drumkit directories (replacing "GMkit" with the actual drumkit name,
where appropriate) and set the actual drumkit dir's Makefiles to recurse
properly into the new drumkits.  The configure script itself mentions GMkit a
few times, so I felt it best to modify that file too, which is where the
*really* bad code comes into place in my ebuild.  But, again, I stress that it
*does* work.  :)

Anyway, enjoy.	Comment if you will...

[Comment 4 CJ Kucera 2003-09-05 22:14:37 UTC]

Oh, also, you'll notice that I commented out the TD-7 drumkit.  This is because some of the samples in that kit contain spaces in the filename, and during the "make install" things bomb out because of it.  I'll figure that one out later, it's time for bed.  :)

[Comment 5 Kasper Souren 2003-09-22 08:23:34 UTC]

Doesn't work here... 
 
Here is some output: 
 
>>> Unpacking EasternHop-1.tar.gz to /var/tmp/portage/hydrogen-0.8.0-r1/work 
/usr/sbin/ebuild.sh: line 36: cd: hydrogen-0.8.0/data/drumkits: No such file 
or directory 
sed: can't read Makefile.in: No such file or directory 
sed: can't read Makefile.am: No such file or directory 
cp: cannot stat `../GMkit/Makefile.*': No such file or directory 
sed: can't read Makefile.am: No such file or directory 
sed: can't read Makefile.in: No such file or directory 
cp: cannot stat `../GMkit/Makefile.*': No such file or directory 
... and some more of this ... 
sed: can't read configure.ac: No such file or directory 
sed: can't read configure: No such file or directory 
sed: can't read configure: No such file or directory 
>>> Source unpacked. 
 
And then later it stops here: 
 
g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/qt/3/include -I/usr/X11R6/include   
-DQT_THREAD_SUPPORT  -D_REENTRANT  -O2 -c -o HydrogenApp.o `test -f 
'HydrogenApp.cpp' || echo './'`HydrogenApp.cpp 
In file included from SongEditor.h:44, 
                 from HydrogenApp.h:37, 
                 from HydrogenApp.cpp:25: 
PatternPropertiesDialog.h:33:40: PatternPropertiesDialog_UI.h: No such file 
or directory 
In file included from SongEditor.h:44, 
                 from HydrogenApp.h:37, 
                 from HydrogenApp.cpp:25: 
PatternPropertiesDialog.h:41: syntax error before `{' token 
PatternPropertiesDialog.h:42: virtual outside class declaration 
PatternPropertiesDialog.h:42: non-member function `const char* className()' 
   cannot have `const' method qualifier 
PatternPropertiesDialog.h:42: virtual outside class declaration 
PatternPropertiesDialog.h:42: virtual outside class declaration 
PatternPropertiesDialog.h:42: virtual outside class declaration 
PatternPropertiesDialog.h:42: virtual outside class declaration 
PatternPropertiesDialog.h: In function `QObject* qObject()': 
PatternPropertiesDialog.h:42: invalid use of `this' in non-member function 
PatternPropertiesDialog.h: At global scope: 
 
... and it goes on and on with loads of errormessages... 
 
 
 
 
 

[Comment 6 CJ Kucera 2003-09-22 08:37:19 UTC]

Hm, I can't reproduce that; just tried out the ebuild on another box and it worked fine.  Those compilation errors look like they're unrelated, too... Perhaps something else is wrong with your box?  It almost sounds like the original libhydrogen tarball was incomplete (couldn't find the data/drumkits directory during my Makefile mangling, and then later in the compile it couldn't find PatternPropertiesDialog_UI.h...)

[Comment 7 Torben Hohn (RETIRED) 2004-01-22 06:11:00 UTC]

done for hydrogen-0.8.1

now we are all waiting for 0.8.2 :)
ladspa effect sends.......