Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 274863

Summary: net-misc/ntp-4.2.4_p7: offset code is broken
Product: Gentoo Linux Reporter: Robin Johnson <robbat2>
Component: [OLD] Core systemAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED TEST-REQUEST    
Severity: critical    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: 20090620_isohunt-ntp_offset-week.png
20090620_isohunt-ntp_offset-day.png

Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-06-20 23:03:18 UTC
As of p7, the offset code seems to be critically broken. See the attached graphs of ntp data.

The upgrade to p7 was performed on the 17th, and almost immediately thereafter, the offset values go to huge levels.

I looked at the diff between the two versions, but I cannot find where the offset code has changed.

I'm restoring p6 with the MOD_NANO patch backported to it until this is resolved.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-06-20 23:06:47 UTC
Created attachment 195308 [details]
20090620_isohunt-ntp_offset-week.png

the 17th is when the upgrade to _p7 was put into place, almost immediately thereafter the offset value goes huge, and does not come down.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-06-20 23:08:02 UTC
Created attachment 195310 [details]
20090620_isohunt-ntp_offset-day.png

At the very end of the graph (the last hour), I put _p6 back onto the machine, with the MOD_NANO patch backported, and the offset value drops close to zero again.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-06-20 23:27:32 UTC
Oh, and it's not box specific, I had this on 13 machines in my network (that were all upgraded on the 17th). ~90 minutes after going back to _p6, all boxes are back within 10ms of the same time (we need accuracy to <10ms for log correlation).

With _p6, we get that <10ms, with _p7 we only get <200ms.
Comment 4 SpanKY gentoo-dev 2009-06-21 23:43:19 UTC
p7 wasnt moved to stable just for the nano issue.  it also has CVE issues associated with it.
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-06-22 00:10:37 UTC
Yup, i'm aware of the CVE, but the offset regression is pretty major for me. Is the patch against p5 on the CVE bug all that's needed to be safe against the exploit? If so, I'll make a revbump of p6 with it in the meantime, so that we have functional+secure.
Comment 6 SpanKY gentoo-dev 2009-06-22 00:58:25 UTC
i remember multiple CVEs being filed in bugzilla and rather than patch things, we simply updated to p7
Comment 7 SpanKY gentoo-dev 2009-12-14 03:10:37 UTC
you can try 4.2.6 which is in the tree now