Bug 274074

Summary:	media-sound/gnomoradio: fails with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED TEST-REQUEST
Severity:	QA
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-13 23:53:02 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-13 23:53:23 UTC

Created attachment 194596 [details]
Build log

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2009-07-18 10:39:51 UTC

Missing -lm, but I didn't see any "LDFLAGS not respected" while building; with just asneeded in LDFLAGS at make.conf. But, it seemed simple enough to fix:

  18 Jul 2009; Samuli Suominen <ssuominen@gentoo.org>
+  gnomoradio-0.15.1.ebuild, +files/gnomoradio-0.15.1-lm.patch:
+  Insert -lm to LIBADD for forced asneeded wrt #274074.

--- gnomoradio-0.15.1.orig/roboradio/mp3/Makefile.am	2004-06-15 08:45:35.000000000 +0300
+++ gnomoradio-0.15.1/roboradio/mp3/Makefile.am	2009-07-18 13:35:08.000000000 +0300
@@ -44,7 +44,7 @@
 	mpg123.h				\
 	tabinit.c				\
 	$(optimized_source)
-libroboradio_mp3_la_LIBADD = -lpthread \
+libroboradio_mp3_la_LIBADD = -lm -lpthread \

No system to test solution, so closing as TEST-REQ.