Bug 272961 – [PATCH] games-action/armagetronad-0.2.7.1-r1 does not emerge

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Martin Väth 2009-06-06 17:48:03 UTC]

armagetronad-0.2.7.1-r1 does not emerge for two reasons:

1. The make rule for src/doc/commands.txt is broken:
It executes "$W/armagetronad --doc" which is bad because
a) This file normally has no execute permissions.
b) Even if one changes permissions, it executes the installed armagetronad which
fails if no version of armagetronad was installed or a version which does not
know about the --doc parameter.

The simple fix for 1. is to make execute "$W/src/tron/armagetronad --doc" instead.

2. There is a problem with the glibc-2.10.1 implementation of strchr which
returns now a "const char *" if it gets a "const char *". The problem can
be solved by a const_cast<char *>(...) although this is not a clean solution
(one should not modify const char entries of strings directly); however, a
clean solution should be done upstream. The const_cast should work currently
with all gcc implementations of the STL library. I attach a corresponding patch.

[Comment 1 Martin Väth 2009-06-06 17:48:50 UTC]

Created attachment 193742 [details, diff]
Fix makefile.in to not access installed armagetronad version

[Comment 2 Martin Väth 2009-06-06 17:49:59 UTC]

Created attachment 193743 [details, diff]
Fix compilation with glibc-2.10.1 by casting (not a clean solution but should work)

[Comment 3 Mr. Bones. (RETIRED) 2009-06-08 17:07:41 UTC]

in portage.  thanks for the bug report and patch