Bug 272274

Summary:	app-misc/toilet: fails with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Samuli Suominen (RETIRED) <ssuominen>
Status:	RESOLVED FIXED
Severity:	QA
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log fixing as-needed issues

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-02 14:50:54 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-02 14:51:07 UTC

Created attachment 193298 [details]
Build log

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2009-06-02 15:10:18 UTC

If fixed this pkg for asneeded before but in a very lazy way. I need to apply a pkgconfig stuff into configure.ac for it to pick it up for the Makefile.am , because it depends on which lib it needs to link

-lcucul

or -lcaca

depending on libcaca version

Please don't remove this pkg, i'll fix it..

Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-02 15:16:44 UTC

I didn't CC treecleaners here ^^; I was going to fix it myself later in case.

Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-10-16 16:50:44 UTC

Created attachment 207328 [details, diff]
fixing as-needed issues

taking advantage of the fact that PKG_CHECK_MODULES(cucul, cucul >= 0.99.beta10) defines cucul_CFLAGS and cucul_LIBS

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2009-10-16 17:09:49 UTC

+  16 Oct 2009; Samuli Suominen <ssuominen@gentoo.org>
+  files/toilet-0.1-asneeded-and-cflags-2.patch:
+  Fix building with LD_AS_NEEDED wrt #272274, thanks to Kacper Kowalik and
+  Diego E. 'Flameeyes' Pettenò.