Summary: | [patch] x11-drivers/xf86-video-radeonhd 1.2.5 Performance enhancement for r6xx/7xx chips | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Conn Clark <conn.o.clark> |
Component: | New packages | Assignee: | Jeffrey Gardner (RETIRED) <je_fro> |
Status: | RESOLVED UPSTREAM | ||
Severity: | enhancement | Keywords: | Inclusion |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | speed up patch |
Description
Conn Clark
2009-05-30 22:54:31 UTC
Created attachment 193019 [details]
speed up patch
Thanks for the patch, but if upstream haven't accepted this because it's too difficult to maintain, how can the gentoo developers be expected to maintain it? Each time there's a version bump, users will lose your speed up, and the devs will start getting bugs filed against the performance drop until they adapt the patch. Given that it's a 168k patch, I doubt any dev will want the task... I strongly urge that you try to address the concerns upstream have over accepting your patch and get it integrated into the main source. I'll assign this to the appropriate developers, just in case they're interested, but don't be surprised if this bug gets closed with UPSTREAM or similar. (In reply to comment #2) > Thanks for the patch, but if upstream haven't accepted this because it's too > difficult to maintain, how can the gentoo developers be expected to maintain > it? Each time there's a version bump, users will lose your speed up, and the > devs will start getting bugs filed against the performance drop until they > adapt the patch. Given that it's a 168k patch, I doubt any dev will want the > task... I don't expect that the gentoo developers maintain it. I also can see why you don't want to include it if users will gripe when the next version bump comes. I am currently maintaining my patch and keeping it up to date with the mainline git. > > I strongly urge that you try to address the concerns upstream have over > accepting your patch and get it integrated into the main source. > > I'll assign this to the appropriate developers, just in case they're > interested, but don't be surprised if this bug gets closed with UPSTREAM or > similar. > Unfortunately to get the speed I have had to write the code to in such a way that it will probably never get accepted up stream. I have done massive amounts of manual inlining and coded things in such away to work around compiler short comings. Sadly changing these things would drop the gains to 1 or 2% at best. My main reason for posting this patch here was done because others requested that I do it. http://forums.gentoo.org/viewtopic-t-767363.html I can fully understand why people won't want to include it in an official ebuild. Perhaps someone could use it to make an unofficial experimental ebuild though. x11 team does not need to be cced here, we definetly wont apply something like this to driver. Maintainer can decide otherwise but then it is up to him to support the stuff :] Cheers Or an overlay might be a good place for this. |