| Summary: | =media-video/transcode-1.1.7: text relocation in aclib | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Rafał Mużyło <galtgendo> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | pageexec, qa |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
fix for "implicit decraration" and strict aliasing
attempt at text relocation fix - incomplete |
||
Created attachment 192645 [details, diff]
fix for "implicit decraration" and strict aliasing
Created attachment 192646 [details, diff]
attempt at text relocation fix - incomplete
I do hope this part is correct.
Rafał, sent any of these to upstream? Not really. While the first one is most probably correct, it's also nearly trivial, so the upstream probably came up with it already. As for the second one, as I'm not sure if it's correct and cause it's incomplete, I don't see a point of sending it upstream, unless at very least somebody verifies its correctness. (In reply to comment #4) > and cause it's incomplete, I don't see a point of sending it upstream, > unless at very least somebody verifies its correctness. You got it wrong way around; upstream is best to review it's own code. AFAIK, transcode is neither upstream for tomsmocomp, nor for the missing aclib bit (I think that part is shared between a few projects). OK, libtomsmocomp is still a no-go, but for transcode 1.1.5, (where most of the cleanup.patch problems were addressed) there's a new '--disable-x86-textrels' switch that fixes TEXTRELs in aclib. And, OK, I was wrong, transcode is (to a point) upstream for aclib. We need refreshed test request and patches for 1.1.7, otherwise I'll close this in a few months as NEEDINFO Well, as I built it with "X a52 aac alsa dvd elibc_glibc iconv imagemagick jpeg kernel_linux mjpeg mmx mp3 mpeg ogg postproc quicktime sdl sse theora truetype userland_GNU v4l vorbis x264 x86 xml xvid", the only warning from the old set, that I still observed, was: TEXTREL usr/lib/transcode/filter_yuvdenoise.so That one, as mentioned in comment 7, gets fixed by adding "--disable-x86-textrels". Obviously, it's x86 specific. + 06 Dec 2011; Samuli Suominen <ssuominen@gentoo.org> transcode-1.1.7.ebuild: + USE="pic" to control text relocation(s) in aclib wrt #271476 by Rafał + Mużyło |
These will going to be two patches: first is (sort of) two part - part that is correct and trivial ("implicit declaration" fixes) and part that looks correct (strict aliasing fixes); second is incomplete - it's an attempt to fix text relocations, based on patch in bug 164425. I'm not sure if it's correct and it's definitely incomplete, cause aclib/memcpy.c (I think) still needs to be fixed.