Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 269803

Summary: subtitleripper-0.3.4-r3 doesn't compile from ~amd64 arch with gcc4.4
Product: Gentoo Linux Reporter: Florian GYS <floriangys>
Component: Current packagesAssignee: Christian Parpart (RETIRED) <trapni>
Severity: normal CC: esigra, rb6, vostorga
Priority: High    
Version: unspecified   
Hardware: AMD64   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 249226    
Attachments: Build.log file
Patch allowing subtitleripper-0.3.4 to build using media-libs/libpng-1.2.36
Patch to current subtitleripper-0.3.4-r3 ebuild

Description Florian GYS 2009-05-14 09:06:42 UTC

subtitleripper-0.3.4-r3 doesn't compile.

Reproducible: Always

Steps to Reproduce:
1.emerge subtitleripper

Actual Results:  
fail to compile

Expected Results:  
should compile fine.

I'm running all packages from ~amd64, except for gcc which is 4.4.
My CFLAGS are safe: -march=native -o2 -pipe
Comment 1 Florian GYS 2009-05-14 09:07:39 UTC
Created attachment 191235 [details]
Build.log file
Comment 2 Florian GYS 2009-05-14 12:58:04 UTC
Commenting out line 335 & 336 in /usr/include/pngconf.h solved this.
Comment 3 Marc O'Connor 2009-05-14 17:03:23 UTC
there is a patch in the files/ dir that would do this automatically if the ebuild had some epatch lines in it. 
Comment 4 Florian GYS 2009-05-15 09:40:15 UTC
(In reply to comment #3)
> there is a patch in the files/ dir that would do this automatically if the
> ebuild had some epatch lines in it. 

There is only one patch in the files directory, and one related epatch line in the ebuild:

epatch "${FILESDIR}/${P}-linkingorder.patch"

Looking at the patch, I don't think it is related to my problem:

Index: subtitleripper/Makefile
--- subtitleripper.orig/Makefile
+++ subtitleripper/Makefile
@@ -70,19 +70,19 @@ vobsub2pgm.o: vobsub2pgm.c vobsub.h spud
 # Target
 subtitle2pgm: subtitle2pgm.o spudec.o
        @echo "Linking $@"
-       @$(CC) $(LIBS) $^ -o $@
+       @$(CC) $^ -o $@ $(LIBS)

 subtitle2vobsub: subtitle2vobsub.o vobsub.o
        @echo "Linking $@"
-       @$(CC) $(LIBS) $^ -o $@
+       @$(CC) $^ -o $@ $(LIBS)

 srttool: srttool.o
        @echo "Linking $@"
-       @$(CC) $(LIBS) -g $^ -o $@
+       @$(CC) -g $^ -o $@ $(LIBS)

 vobsub2pgm: vobsub2pgm.o vobsub.o spudec.o
        @echo "Linking $@"
-       @$(CC) $(LIBS) -g $^ -o $@
+       @$(CC) -g $^ -o $@ $(LIBS)

 .PHONY: clean dist rpm

The patch you talk about seems missing from this ebuild.
Comment 5 R Bar-On 2009-05-17 13:12:35 UTC
same with gcc 4.3.3
Comment 6 R Bar-On 2009-05-17 13:24:09 UTC
this is clearly an error in media-libs/libpng.  Those two lines are:

          __pngconf.h__ in libpng already includes setjmp.h;
           __dont__ include it again.;

cc'ing the maintainer of that package,
Comment 7 R Bar-On 2009-05-17 13:28:25 UTC
from the end of INSTALL file from libpng:

"If you encounter a compiler error message complaining about the
      __png.h__ already includes setjmp.h;
      __dont__ include it again.;
This means you have compiled another module that includes setjmp.h,
which is hazardous because the two modules might not include exactly
the same setjmp.h.  If you are sure that you know what you are doing
and that they are exactly the same, then you can comment out or
delete the two lines.  Better yet, use the cexcept interface
instead, as demonstrated in contrib/visupng of the libpng distribution.

Further information can be found in the README and libpng.txt
files, in the individual makefiles, in png.h, and the manual pages
libpng.3 and png.5."
Comment 8 SpanKY gentoo-dev 2009-05-17 16:49:49 UTC
those lines arent there for fun ...
Comment 9 R Bar-On 2009-05-17 16:50:46 UTC
I assumed not, but they break compilation of this particular package.
Comment 10 Víctor Ostorga (RETIRED) gentoo-dev 2009-05-19 15:17:49 UTC
Tested with gcc 4.4 on amd64 and it compiled fine.

I think the following warning is taked as a compile error in your system:

/usr/include/pngconf.h:328:2: warning: #warning __pngconf.h__ already includes setjmp.h;
/usr/include/pngconf.h:329:2: warning: #warning __dont__ include it again.;

Please attach your emerge --info and the version of media-libs/libpng you are using
Comment 11 R Bar-On 2009-05-19 15:21:12 UTC

emerge --info:
Portage 2.2_rc33 (default/linux/amd64/2008.0/desktop, gcc-4.3.3, glibc-2.10.1-r0, 2.6.30-rc6-00065-g3633832 x86_64)
System uname: Linux-2.6.30-rc6-00065-g3633832-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T9300_@_2.50GHz-with-gentoo-2.0.0
Timestamp of tree: Tue, 19 May 2009 11:45:02 +0000
ccache version 2.4 [enabled]
app-shells/bash:     4.0_p24
dev-java/java-config: 2.1.7
dev-lang/python:     2.6.2
dev-python/pycrypto: 2.0.1-r8
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.6.4
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.3-r2
sys-apps/sandbox:    1.9
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.5, 1.7.9-r1, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.19.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.29
ACCEPT_KEYWORDS="amd64 ~amd64"
CFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
FEATURES="ccache distlocks fixpackages parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-orphans userfetch"
MAKEOPTS="-j3 -l3"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTDIR_OVERLAY="/usr/portage/local/layman/desktop-effects /usr/portage/local/layman/zen-overlay /usr/portage/local/layman/java-overlay /usr/portage/local/layman/mozilla /usr/portage/local/layman/sunrise /usr/portage/local/layman/kde-testing /usr/portage/local/layman/x11 /usr/local/portage"
USE="X aac acl acpi alsa amd64 bash-completion berkdb branding bzip2 cairo cdr cli cracklib crypt cups dbus dri dvd dvdr dvdread encode esd fam fortran gdbm gif glitz gnutls gpm gstreamer gtk hal iconv ieee1394 ipw4965 isdnlog jpeg kde4 kpathsea ldap libnotify mad midi mikmod mmx mp3 mpeg mudflap multilib ncurses nls nognome nptl nptlonly ogg opengl openmp pam pcre pdf perl png ppds pppd python qt3support qt4 quicktime readline realmedia reflection samba sdl semantic-desktop session spell spl sse sse2 ssl ssse3 startup-notification svg sysfs tcpd tetex theora tiff truetype type1 unicode usb vorbis wmp x264 xcb xcomposite xml xorg xulrunner xv xvid zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="intel vesa"
Comment 12 Víctor Ostorga (RETIRED) gentoo-dev 2009-05-19 17:10:38 UTC
This bug is not reladed to gcc 4.4 and should not be blocking bug 249226 .
It is related to media-libs/libpng-1.2.36 , check bug 270453 .

To put it simple media-libs/libpng-1.2.36 is not patching pngconf.h so spudec.c fails to build, because it includes "png.h" .
Comment 13 Víctor Ostorga (RETIRED) gentoo-dev 2009-05-20 03:09:07 UTC
Created attachment 191867 [details, diff]
Patch allowing subtitleripper-0.3.4 to build using media-libs/libpng-1.2.36

> ------- Comment #2 from  2009-05-19 23:17 0000 -------
> fix the application in question.  that patch was dropped on purpose.

This is the fix
And stills it is not related to bug 249226
Comment 14 Víctor Ostorga (RETIRED) gentoo-dev 2009-05-20 03:10:51 UTC
Created attachment 191869 [details, diff]
Patch to current subtitleripper-0.3.4-r3 ebuild
Comment 15 Ryan Hill (RETIRED) gentoo-dev 2009-05-31 01:15:48 UTC