Bug 268938 – net-misc/memcached: ALLOW_SLABS_REASSIGN USE flag

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description werner maier 2009-05-07 13:44:27 UTC]

the compile time option ALLOW_SLABS_REASSIGN should be configurable via useflag. 

more information about ALLOW_SLABS_REASSIGN here:
http://code.google.com/p/memcached/wiki/MemcachedSlabAllocator
(it's quite an internal thing...)

I allready have patches that work for me.
I'll file that bug and add the patches after.

[Comment 1 werner maier 2009-05-07 13:48:50 UTC]

Created attachment 190621 [details]
ebuild and necessary file for the files/ directory as tgz.

the metadata.xml file might need to be patched:

<use>
    <flag name="slabsreassign">define ALLOW_SLABS_REASSIGN</flag>
</use>

[Comment 2 Robin Johnson 2009-05-08 20:55:16 UTC]

Please do NOT attach tarballs. There are security concerns in opening untrusted binary data on Bugzilla, additionally, it's a pain to do quick review in a web browser that is possible with diffs.

Please re-attach as non-tarball. Individual files, diffs where possible

[Comment 3 werner maier 2009-05-08 21:27:59 UTC]

> Please do NOT attach tarballs. There are security concerns [...]
> additionally, it's a pain to do quick review [...]

sorry about that. 

[Comment 4 werner maier 2009-05-08 21:30:01 UTC]

Created attachment 190708 [details, diff]
diff to memcached-1.2.6.ebuild

adds a patch if use flag is given

[Comment 5 werner maier 2009-05-08 21:30:45 UTC]

Created attachment 190710 [details]
needed file for files/-section in portage

[Comment 6 Robin Johnson 2009-05-08 21:34:18 UTC]

That patch is a yucky way of doing it.

Here's a better one-liner for the ebuild:
use slabs-reassign && append-flags -DALLOW_SLABS_REASSIGN

[Comment 7 werner maier 2009-05-08 21:36:09 UTC]

> That patch is a yucky way of doing it.

it was the best I knew :)

> Here's a better one-liner for the ebuild:
> use slabs-reassign && append-flags -DALLOW_SLABS_REASSIGN

hey - nice day. learned something :)

[Comment 8 werner maier 2009-05-12 07:38:46 UTC]

if done like this

> > Here's a better one-liner for the ebuild:
> > use slabs-reassign && append-flags -DALLOW_SLABS_REASSIGN

then a 

  inherit flag-o-matic 

must also be added, else it won't be used.

btw: just discovered: 
this won't compile with gcc-4.1+, but it compiles with gcc-3.3.5 (yes, I know it is ages old).

I'll file a bug at the memcached issue tracker.

[Comment 9 Robin Johnson 2009-05-14 23:14:12 UTC]

In 1.3.3-r1 now.